From: Thomas Gleixner <tglx@linutronix.de>
To: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
mingo@kernel.org, paulmck@linux.vnet.ibm.com,
josh@joshtriplett.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] preempt/hardirq.h: Clarify PREEMPT_ACTIVE bit location
Date: Tue, 14 Aug 2012 12:18:49 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1208141216120.32033@ionos> (raw)
In-Reply-To: <502A0C19.6010007@linux.vnet.ibm.com>
On Tue, 14 Aug 2012, Srivatsa S. Bhat wrote:
>
> By default, the PREEMPT_ACTIVE flag is bit 27, but different
> architectures can override that. Update the comment to reflect
> this fact.
Is there any sensible reason why architectures need to override that?
I can't find one.
If there is none, then we should just remove all the overrides from
the arch code instead. If there is a reason, then it should be
documented.
Thanks,
tglx
next prev parent reply other threads:[~2012-08-14 10:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 19:24 [PATCH] preempt/hardirq.h: Fix comment about PREEMPT_ACTIVE bit location Srivatsa S. Bhat
2012-07-26 15:15 ` [tip:sched/urgent] sched: " tip-bot for Srivatsa S. Bhat
2012-07-31 3:49 ` [PATCH] preempt/hardirq.h: " Steven Rostedt
2012-08-14 8:26 ` Srivatsa S. Bhat
2012-08-14 8:28 ` [PATCH] preempt/hardirq.h: Clarify " Srivatsa S. Bhat
2012-08-14 10:18 ` Thomas Gleixner [this message]
2012-08-14 12:46 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1208141216120.32033@ionos \
--to=tglx@linutronix.de \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).