From: Thomas Gleixner <tglx@linutronix.de>
To: NeilBrown <neilb@suse.de>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
"Shilimkar, Santosh" <santosh.shilimkar@ti.com>,
lkml <linux-kernel@vger.kernel.org>,
linux-omap@vger.kernel.org,
Kevin Hilman <khilman@deeprootsystems.com>
Subject: Re: Seeking clarity on IRQCHIP_MASK_ON_SUSPEND
Date: Mon, 10 Sep 2012 12:28:35 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1209101215300.2724@ionos> (raw)
In-Reply-To: <20120910165127.37dd07f3@notabene.brown>
On Mon, 10 Sep 2012, NeilBrown wrote:
>
> The IRQCHIP_MASK_ON_SUSPEND flag seems to be hard to use correctly, so either
> I'm understanding it wrongly, or it could be made easier to use.
> If the first case, I'm hoping that some improvement to documentation might
> result. If the second, then maybe we can fix the code.
...
> Is anyone able to give a definitive answer on this? Should
> IRQCHIP_MASK_ON_SUSPEND be removed?
The whole point of IRQCHIP_MASK_ON_SUSPEND is to deal with hardware
designed by geniuses.
Most SoCs have a way to mark the interrupts which serve as a wake up
source as such. All other interrupts are magically "masked" on entry
to suspend.
Now there is hardware which is missing such a control, so we need to
mask the non wakeup interrupts right before going into suspend.
That's what IRQCHIP_MASK_ON_SUSPEND does. Not more, not less. See
commit d209a699a0b for more ugly details.
You might be looking for a different functionality. Can you explain
what you need?
Thanks,
tglx
next prev parent reply other threads:[~2012-09-10 10:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 6:51 Seeking clarity on IRQCHIP_MASK_ON_SUSPEND NeilBrown
2012-09-10 10:28 ` Thomas Gleixner [this message]
2012-09-10 10:56 ` Shilimkar, Santosh
2012-09-10 13:25 ` Thomas Gleixner
2012-09-10 23:42 ` NeilBrown
2012-09-11 13:20 ` Thomas Gleixner
2012-09-11 23:21 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1209101215300.2724@ionos \
--to=tglx@linutronix.de \
--cc=khilman@deeprootsystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=neilb@suse.de \
--cc=rjw@sisk.pl \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).