From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752418Ab2KSG6M (ORCPT ); Mon, 19 Nov 2012 01:58:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54757 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751252Ab2KSG6L (ORCPT ); Mon, 19 Nov 2012 01:58:11 -0500 Date: Mon, 19 Nov 2012 12:27:53 +0530 (IST) From: P J P X-X-Sender: pjp@javelin.pnq.redhat.com To: Kees Cook cc: Al Viro , linux-kernel@vger.kernel.org, Andrew Morton , Josh Triplett , Serge Hallyn , linux-fsdevel@vger.kernel.org, halfdog Subject: Re: [PATCH] exec: do not leave bprm->interp on stack In-Reply-To: Message-ID: References: <20121024232032.GA31129@www.outflux.net> <20121025120952.GI2616@ZenIV.linux.org.uk> <20121025123843.GJ2616@ZenIV.linux.org.uk> <20121026183601.GR2616@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +-- On Sun, 18 Nov 2012, Kees Cook wrote --+ | This is the second problem. I view this as less critical because it's only | 64 instead of 4, but it certainly should be solved as well. I don't mean to be rude, but the patch I had sent solves both of these problems with much less performance hit. Please see -> https://lkml.org/lkml/2012/10/26/442 Worst case: instead of 2^6(64) recursions, it would make only 4 calls to request_module() function. find_module() does not resolve module aliases, it could be removed from the above patch. Please pardon me if I came across rude or offensive, I'm only trying to make a case. -- Prasad J Pandit / Red Hat Security Response Team DB7A 84C5 D3F9 7CD1 B5EB C939 D048 7860 3655 602B