From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH 4/4] (RFC) X86: add IPI tracepoints
Date: Wed, 23 Jul 2014 18:00:11 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.11.1407231751130.6061@knanqh.ubzr> (raw)
In-Reply-To: <20140721185459.54c81bd5@gandalf.local.home>
On Mon, 21 Jul 2014, Steven Rostedt wrote:
> On Fri, 18 Jul 2014 16:59:50 -0400 (EDT)
> Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
>
> > On Fri, 18 Jul 2014, Steven Rostedt wrote:
> >
> > > On Fri, 18 Jul 2014 01:18:55 -0400
> > > Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
> > >
> > >
> > > > diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c
> > > > index be8e1bde07..e154d176cf 100644
> > > > --- a/arch/x86/kernel/smp.c
> > > > +++ b/arch/x86/kernel/smp.c
> > > > @@ -31,6 +31,12 @@
> > > > #include <asm/apic.h>
> > > > #include <asm/nmi.h>
> > > > #include <asm/trace/irq_vectors.h>
> > > > +
> > > > +#define CREATE_TRACE_POINTS
> > > > +#undef TRACE_INCLUDE_PATH
> > > > +#undef TRACE_INCLUDE_FILE
> > >
> > > I'm curious to why you added the #undefs. I wouldn't think they were
> > > needed.
> >
> > They are needed because asm/trace/irq_vectors.h included prior that
> > point defines them for itself and that makes the inclusion of
> > trace/events/ipi.h fail.
> >
>
> Bah, I tried to get rid of the need for those, but it seems that the
> macro magic is getting a bit out of hand. I need a new macro magic
> hat :-p
>
> What you got here will have to do.
OK.
Now the real question: should I submit it for mainline? I'm a little
bothered by the fact that all exception vectors already have tracepoints
of their own, albeit deeply tied to X86 nomenclature. But nothing that
relates to IPI sources. This patch fixes that by adding some
tracepoints alongside existing ones which may go a long way in making
their instrumentation with generic (arch independent) tools.
What do people think?
Nicolas
next prev parent reply other threads:[~2014-07-23 22:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 5:18 [PATCH 0/4] basic IPI tracing Nicolas Pitre
2014-07-18 5:18 ` [PATCH 1/4] tracepoint: add generic tracepoint definitions for " Nicolas Pitre
2014-07-23 13:24 ` Daniel Lezcano
2014-07-18 5:18 ` [PATCH 2/4] ARM: add IPI tracepoints Nicolas Pitre
2014-07-18 20:04 ` Steven Rostedt
2014-07-18 20:55 ` Nicolas Pitre
2014-07-18 21:22 ` Steven Rostedt
2014-07-19 2:55 ` Nicolas Pitre
2014-07-19 3:30 ` Steven Rostedt
2014-07-19 19:10 ` Ard Biesheuvel
2014-07-19 20:28 ` Steven Rostedt
2014-07-19 20:50 ` Ard Biesheuvel
2014-07-19 21:56 ` Steven Rostedt
2014-07-19 21:59 ` Nicolas Pitre
2014-07-23 22:18 ` Nicolas Pitre
2014-07-18 5:18 ` [PATCH 3/4] ARM64: " Nicolas Pitre
2014-07-21 10:36 ` Catalin Marinas
2014-07-18 5:18 ` [PATCH 4/4] (RFC) X86: " Nicolas Pitre
2014-07-18 20:27 ` Steven Rostedt
2014-07-18 20:59 ` Nicolas Pitre
2014-07-21 22:54 ` Steven Rostedt
2014-07-23 22:00 ` Nicolas Pitre [this message]
2014-07-20 20:25 ` Davidlohr Bueso
2014-07-21 22:35 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.11.1407231751130.6061@knanqh.ubzr \
--to=nicolas.pitre@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).