From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932201AbcEMTmt (ORCPT ); Fri, 13 May 2016 15:42:49 -0400 Received: from casper.infradead.org ([85.118.1.10]:34777 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932128AbcEMTms (ORCPT ); Fri, 13 May 2016 15:42:48 -0400 Date: Fri, 13 May 2016 20:42:42 +0100 (BST) From: James Simmons To: Muhammad Falak R Wani cc: Oleg Drokin , devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org Subject: Re: [lustre-devel] [PATCH] staging: lustre: use setup_timer(). In-Reply-To: <1462980251-6608-1-git-send-email-falakreyaz@gmail.com> Message-ID: References: <1462980251-6608-1-git-send-email-falakreyaz@gmail.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160513_204242_811048_8E5E5AD5 X-CRM114-Status: GOOD ( 10.10 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.0 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Use setup_timer() for initializing the timer, instead of structure > assignments. > This is the preferred/standard way. > > Signed-off-by: Muhammad Falak R Wani Acked-by: James Simmons > --- > drivers/staging/lustre/lnet/lnet/net_fault.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c b/drivers/staging/lustre/lnet/lnet/net_fault.c > index 7d76f28..e4aceb7 100644 > --- a/drivers/staging/lustre/lnet/lnet/net_fault.c > +++ b/drivers/staging/lustre/lnet/lnet/net_fault.c > @@ -760,9 +760,7 @@ lnet_delay_rule_add(struct lnet_fault_attr *attr) > wait_event(delay_dd.dd_ctl_waitq, delay_dd.dd_running); > } > > - init_timer(&rule->dl_timer); > - rule->dl_timer.function = delay_timer_cb; > - rule->dl_timer.data = (unsigned long)rule; > + setup_timer(&rule->dl_timer, delay_timer_cb, (unsigned long)rule); > > spin_lock_init(&rule->dl_lock); > INIT_LIST_HEAD(&rule->dl_msg_list); > -- > 1.9.1 > > _______________________________________________ > lustre-devel mailing list > lustre-devel@lists.lustre.org > http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org >