From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752566AbcFNRKy (ORCPT <rfc822;w@1wt.eu>);
	Tue, 14 Jun 2016 13:10:54 -0400
Received: from mail-qg0-f47.google.com ([209.85.192.47]:36860 "EHLO
	mail-qg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751356AbcFNRKw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 14 Jun 2016 13:10:52 -0400
Date: Tue, 14 Jun 2016 13:10:47 -0400 (EDT)
From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
        Rusty Russell <rusty@rustcorp.com.au>,
        Michal Simek <michal.simek@xilinx.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Arnd Bergmann <arnd@arndb.de>, Michal Marek <mmarek@suse.cz>
Subject: Re: [PATCH 2/5] export.h: use __is_defined() to check if __KSYM_*
 is defined
In-Reply-To: <1465883938-25194-2-git-send-email-yamada.masahiro@socionext.com>
Message-ID: <alpine.LFD.2.20.1606141309560.1714@knanqh.ubzr>
References: <1465883938-25194-1-git-send-email-yamada.masahiro@socionext.com> <1465883938-25194-2-git-send-email-yamada.masahiro@socionext.com>
User-Agent: Alpine 2.20 (LFD 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 14 Jun 2016, Masahiro Yamada wrote:

> Here the need is for a macro that checks whether the given symbol is
> defined or not, which has nothing to do with config.
> 
> The new macro __is_defined() is a better fit for this case.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Acked-by: Nicolas Pitre <nico@linaro.org>

> ---
> 
>  include/linux/export.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/export.h b/include/linux/export.h
> index 2f9ccbe..c565f87 100644
> --- a/include/linux/export.h
> +++ b/include/linux/export.h
> @@ -82,7 +82,7 @@ extern struct module __this_module;
>  #include <generated/autoksyms.h>
>  
>  #define __EXPORT_SYMBOL(sym, sec)				\
> -	__cond_export_sym(sym, sec, config_enabled(__KSYM_##sym))
> +	__cond_export_sym(sym, sec, __is_defined(__KSYM_##sym))
>  #define __cond_export_sym(sym, sec, conf)			\
>  	___cond_export_sym(sym, sec, conf)
>  #define ___cond_export_sym(sym, sec, enabled)			\
> -- 
> 1.9.1
> 
>