From: Stafford Horne <shorne@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Jonas Bonn <jonas@southpole.se>,
linux-kernel@vger.kernel.org, openrisc@lists.librecores.org
Subject: Re: [PATCH] openrisc: remove the redundant of_platform_populate
Date: Mon, 12 Sep 2016 19:40:33 +0900 (JST) [thread overview]
Message-ID: <alpine.LFD.2.20.1609121936080.2354@lianli.shorne-pla.net> (raw)
In-Reply-To: <20160830151059.23353-1-robh@kernel.org>
On Tue, 30 Aug 2016, Rob Herring wrote:
> The of_platform_populate call in the openrisc arch code is now redundant
> as the DT core provides a default call. Openrisc has a NULL match table
> which means only top level nodes with compatible strings will have
> devices creates. The default version will also descend nodes in the
> match table such as "simple-bus" which should be fine as openrisc
> doesn't have any of these (though it is preferred that memory-mapped
> peripherals be grouped under a bus node(s)).
This looks fine to me. I am not sure if you got a reply from Jonas, but
he hasn't been active maintainer for a while.
We are working on getting this sorted out.
-Stafford
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Jonas Bonn <jonas@southpole.se>
> ---
> arch/openrisc/kernel/setup.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/openrisc/kernel/setup.c b/arch/openrisc/kernel/setup.c
> index b4ed8b3..d2f78cf7 100644
> --- a/arch/openrisc/kernel/setup.c
> +++ b/arch/openrisc/kernel/setup.c
> @@ -38,7 +38,6 @@
> #include <linux/of.h>
> #include <linux/memblock.h>
> #include <linux/device.h>
> -#include <linux/of_platform.h>
>
> #include <asm/sections.h>
> #include <asm/segment.h>
> @@ -219,15 +218,6 @@ void __init or32_early_setup(void *fdt)
> early_init_devtree(fdt);
> }
>
> -static int __init openrisc_device_probe(void)
> -{
> - of_platform_populate(NULL, NULL, NULL, NULL);
> -
> - return 0;
> -}
> -
> -device_initcall(openrisc_device_probe);
> -
> static inline unsigned long extract_value_bits(unsigned long reg,
> short bit_nr, short width)
> {
> --
> 2.9.3
prev parent reply other threads:[~2016-09-12 10:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 15:10 [PATCH] openrisc: remove the redundant of_platform_populate Rob Herring
2016-09-12 10:40 ` Stafford Horne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1609121936080.2354@lianli.shorne-pla.net \
--to=shorne@gmail.com \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=openrisc@lists.librecores.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).