From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751441AbcISO62 (ORCPT ); Mon, 19 Sep 2016 10:58:28 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:36306 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751207AbcISO60 (ORCPT ); Mon, 19 Sep 2016 10:58:26 -0400 From: Stafford Horne X-Google-Original-From: Stafford Horne Date: Mon, 19 Sep 2016 23:58:21 +0900 (JST) To: Jonas Bonn cc: Stafford Horne , Stefan Kristiansson , Andrew Morton , linux-kernel@vger.kernel.org, Rob Herring Subject: Re: [PATCH 7/7] openrisc: remove the redundant of_platform_populate In-Reply-To: <57DFF6EC.2070806@southpole.se> Message-ID: References: <1474036985-20981-1-git-send-email-shorne@gmail.com> <1474036985-20981-8-git-send-email-shorne@gmail.com> <57DFF6EC.2070806@southpole.se> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Sep 2016, Jonas Bonn wrote: > On 09/16/2016 04:43 PM, Stafford Horne wrote: >> From: Rob Herring >> >> The of_platform_populate call in the openrisc arch code is now redundant >> as the DT core provides a default call. Openrisc has a NULL match table >> which means only top level nodes with compatible strings will have >> devices creates. The default version will also descend nodes in the >> match table such as "simple-bus" which should be fine as openrisc >> doesn't have any of these (though it is preferred that memory-mapped >> peripherals be grouped under a bus node(s)). >> >> Signed-off-by: Rob Herring >> Cc: Jonas Bonn >> Signed-off-by: Stafford Horne > > Yes, this is fine, but trivial/generic stuff like this doesn't really need to > go via the OpenRISC repo, anyway. That's right, however I didnt see anyone pick it up so I included it here. >> --- >> arch/openrisc/kernel/setup.c | 10 ---------- >> 1 file changed, 10 deletions(-) >> >> diff --git a/arch/openrisc/kernel/setup.c b/arch/openrisc/kernel/setup.c >> index b4ed8b3..d2f78cf 100644 >> --- a/arch/openrisc/kernel/setup.c >> +++ b/arch/openrisc/kernel/setup.c >> @@ -38,7 +38,6 @@ >> #include >> #include >> #include >> -#include >> >> #include >> #include >> @@ -219,15 +218,6 @@ void __init or32_early_setup(void *fdt) >> early_init_devtree(fdt); >> } >> >> -static int __init openrisc_device_probe(void) >> -{ >> - of_platform_populate(NULL, NULL, NULL, NULL); >> - >> - return 0; >> -} >> - >> -device_initcall(openrisc_device_probe); >> - >> static inline unsigned long extract_value_bits(unsigned long reg, >> short bit_nr, short width) >> { > >