From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966559AbcKLQcV (ORCPT ); Sat, 12 Nov 2016 11:32:21 -0500 Received: from mail-qt0-f179.google.com ([209.85.216.179]:33404 "EHLO mail-qt0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966442AbcKLQcT (ORCPT ); Sat, 12 Nov 2016 11:32:19 -0500 Date: Sat, 12 Nov 2016 11:32:15 -0500 (EST) From: Nicolas Pitre To: Florian Fainelli cc: linux-kernel@vger.kernel.org, Russell King , Catalin Marinas , Will Deacon , Arnd Bergmann , Chris Brandt , Pratyush Anand , Ard Biesheuvel , Mark Rutland , James Morse , Neeraj Upadhyay , Laura Abbott , Andrew Morton , Vlastimil Babka , Michal Hocko , "Kirill A. Shutemov" , Jerome Marchand , Konstantin Khlebnikov , Joonsoo Kim , "moderated list:ARM PORT" , "open list:GENERIC INCLUDE/ASM HEADER FILES" , "open list:MEMORY MANAGEMENT" Subject: Re: [PATCH RFC] mm: Add debug_virt_to_phys() In-Reply-To: <55bd0bb5-c11c-12bc-7d73-520ae3901f03@gmail.com> Message-ID: References: <20161112004449.30566-1-f.fainelli@gmail.com> <55bd0bb5-c11c-12bc-7d73-520ae3901f03@gmail.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323328-1792465344-1478968337=:1618" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-1792465344-1478968337=:1618 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT On Fri, 11 Nov 2016, Florian Fainelli wrote: > Le 11/11/2016 à 17:49, Nicolas Pitre a écrit : > > On Fri, 11 Nov 2016, Florian Fainelli wrote: > > > >> When CONFIG_DEBUG_VM is turned on, virt_to_phys() maps to > >> debug_virt_to_phys() which helps catch vmalloc space addresses being > >> passed. This is helpful in debugging bogus drivers that just assume > >> linear mappings all over the place. > >> > >> For ARM, ARM64, Unicore32 and Microblaze, the architectures define > >> __virt_to_phys() as being the functional implementation of the address > >> translation, so we special case the debug stub to call into > >> __virt_to_phys directly. > >> > >> Signed-off-by: Florian Fainelli > >> --- > >> arch/arm/include/asm/memory.h | 4 ++++ > >> arch/arm64/include/asm/memory.h | 4 ++++ > >> include/asm-generic/memory_model.h | 4 ++++ > >> mm/debug.c | 15 +++++++++++++++ > >> 4 files changed, 27 insertions(+) > >> > >> diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h > >> index 76cbd9c674df..448dec9b8b00 100644 > >> --- a/arch/arm/include/asm/memory.h > >> +++ b/arch/arm/include/asm/memory.h > >> @@ -260,11 +260,15 @@ static inline unsigned long __phys_to_virt(phys_addr_t x) > >> * translation for translating DMA addresses. Use the driver > >> * DMA support - see dma-mapping.h. > >> */ > >> +#ifndef CONFIG_DEBUG_VM > >> #define virt_to_phys virt_to_phys > >> static inline phys_addr_t virt_to_phys(const volatile void *x) > >> { > >> return __virt_to_phys((unsigned long)(x)); > >> } > >> +#else > >> +#define virt_to_phys debug_virt_to_phys > >> +#endif > > [...] > > > > Why don't you do something more like: > > > > static inline phys_addr_t virt_to_phys(const volatile void *x) > > { > > + debug_virt_to_phys(x); > > return __virt_to_phys((unsigned long)(x)); > > } > > > > [...] > > > > static inline void debug_virt_to_phys(const void *address) > > { > > #ifdef CONFIG_DEBUG_VM > > BUG_ON(is_vmalloc_addr(address)); > > #endif > > } > > > > ? > > This is how I started doing it initially, but to get the > is_vmalloc_addr() definition, we need to include linux/mm.h and then > everything falls apart because of the include and dependencies chain. We > could open code the is_vmalloc_addr() check because that's simple > enough, but we still need VMALLOC_START and VMALLOC_END and to get there > we need to include pgtable.h, and there are still some inclusion > problems in doing so. > > The other reason was to avoid putting the same checks in architecture > specific code, except for those like ARM/ARM64/Unicore32/Microblaze > where I could not find a simple way to undefined virt_to_phys and > redefine it to debug_virt_to_phys. You could still move the check out of line like in your patch. But the debug function doesn't have to be the one returning the translated address. This has the advantage of cutting on the amount of ifdefery. Nicolas --8323328-1792465344-1478968337=:1618--