From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752752AbdJUCTf (ORCPT ); Fri, 20 Oct 2017 22:19:35 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:18235 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751628AbdJUCTe (ORCPT ); Fri, 20 Oct 2017 22:19:34 -0400 Date: Sat, 21 Oct 2017 06:19:19 +0400 (+04) From: James Morris X-X-Sender: james.l.morris@t440 To: David Howells cc: linux-security-module@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk, linux-efi@vger.kernel.org, matthew.garrett@nebula.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, jforbes@redhat.com Subject: Re: [PATCH 26/27] efi: Add an EFI_SECURE_BOOT flag to indicate secure boot mode In-Reply-To: <150842483172.7923.2791223614506312745.stgit@warthog.procyon.org.uk> Message-ID: References: <150842463163.7923.11081723749106843698.stgit@warthog.procyon.org.uk> <150842483172.7923.2791223614506312745.stgit@warthog.procyon.org.uk> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 Oct 2017, David Howells wrote: > + if (efi_enabled(EFI_BOOT)) { > + switch (mode) { > + case efi_secureboot_mode_disabled: > + pr_info("Secure boot disabled\n"); > + break; > + case efi_secureboot_mode_enabled: > + set_bit(EFI_SECURE_BOOT, &efi.flags); > + pr_info("Secure boot enabled\n"); > + break; > + default: > + pr_info("Secure boot could not be determined\n"); Perhaps make this pr_warning and include the unknown mode value? -- James Morris