From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751639AbdJZTGw (ORCPT <rfc822;w@1wt.eu>);
        Thu, 26 Oct 2017 15:06:52 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:46526 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751236AbdJZTGv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 26 Oct 2017 15:06:51 -0400
Date: Thu, 26 Oct 2017 21:06:29 +0200 (CEST)
From: James Morris <james.l.morris@oracle.com>
X-X-Sender: james.l.morris@localhost
To: Linus Torvalds <torvalds@linux-foundation.org>
cc: John Johansen <john.johansen@canonical.com>,
        James Bottomley <James.Bottomley@hansenpartnership.com>,
        Thorsten Leemhuis <regressions@leemhuis.info>,
        Vlastimil Babka <vbabka@suse.cz>,
        Seth Arnold <seth.arnold@canonical.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: regression in 4.14-rc2 caused by apparmor: add base infastructure
 for socket mediation
In-Reply-To: <CA+55aFy8n1TyJdWcy9jjsF7K7RwvaAc3_P7u8KFa-o7mziuc_g@mail.gmail.com>
Message-ID: <alpine.LFD.2.20.1710262105380.11949@localhost>
References: <1507003338.3174.4.camel@HansenPartnership.com> <e6c9af5c-ca42-ee35-5cc0-1a3ba80144b9@canonical.com> <1507007707.3082.16.camel@HansenPartnership.com> <5d57381f-e915-1b8f-7838-eba46ab89f34@suse.cz> <ba463a0b-05bc-9b87-8ed2-c97b54361360@canonical.com>
 <c0cbecb6-63c8-17a6-9c5e-59de27d3c5e9@leemhuis.info> <1508842981.3187.5.camel@HansenPartnership.com> <722a6eda-e834-30f8-bf57-ef6c596816f6@canonical.com> <CA+55aFwiiQYJ+YoLKCXjN_beDVfu38mg=Ggg5LFOcqHE8Qi7Zw@mail.gmail.com> <alpine.LFD.2.20.1710262054190.11949@localhost>
 <CA+55aFy8n1TyJdWcy9jjsF7K7RwvaAc3_P7u8KFa-o7mziuc_g@mail.gmail.com>
User-Agent: Alpine 2.20 (LFD 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 26 Oct 2017, Linus Torvalds wrote:

> On Thu, Oct 26, 2017 at 8:54 PM, James Morris <james.l.morris@oracle.com> wrote:
> > On Thu, 26 Oct 2017, Linus Torvalds wrote:
> >
> >> I'm *very* unhappy with the security layer as is
> >
> > What are you unhappy with?
> 
> We had two big _fundamental_ problems this merge window:
> 
>  - untested code that clearly didn't do what it claimed it did, and
> which caused me to not even accept the main pull request
> 
>  - apparmor code that had a regression, where it took three weeks for
> that regression to be escalated to me simply because the developer was
> denying the regression.
> 
> Tell me why I *shouldn't* be unhappy with the security layer?
> 
> I shouldn't be in the situation where I start reviewing the code and
> go "that can't be right".
> 
> And I *definitely* shouldn't be in the situation where I need to come
> in three weeks later and tell people what a regression is!

Agreed on both counts, and sorry for these problems.

-- 
James Morris
<james.l.morris@oracle.com>