From: Jules Irenge <jbi.octave@gmail.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Jules Irenge <jbi.octave@gmail.com>,
gregkh@linuxfoundation.org, jerome.pouiller@silabs.com,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Boqun.Feng@microsoft.com
Subject: Re: [PATCH] staging: wfx: add gcc extension __force cast
Date: Mon, 11 Nov 2019 13:51:33 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.21.1911111347380.226731@ninjahub.org> (raw)
In-Reply-To: <20191109091913.GV26530@ZenIV.linux.org.uk>
On Sat, 9 Nov 2019, Al Viro wrote:
> On Fri, Nov 08, 2019 at 11:38:37PM +0000, Jules Irenge wrote:
> > Add gcc extension __force and __le32 cast to fix warning issued by Sparse tool."warning: cast to restricted __le32"
> >
> > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> > ---
> > drivers/staging/wfx/debug.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/wfx/debug.c b/drivers/staging/wfx/debug.c
> > index 0a9ca109039c..aa7b2dd691b9 100644
> > --- a/drivers/staging/wfx/debug.c
> > +++ b/drivers/staging/wfx/debug.c
> > @@ -72,7 +72,7 @@ static int wfx_counters_show(struct seq_file *seq, void *v)
> > return -EIO;
> >
> > #define PUT_COUNTER(name) \
> > - seq_printf(seq, "%24s %d\n", #name ":", le32_to_cpu(counters.count_##name))
> > + seq_printf(seq, "%24s %d\n", #name ":", le32_to_cpu((__force __le32)(counters.count_##name)))
>
> NAK. force-cast (and it's not a gcc extension, BTW - it's sparse) is basically
> "I know better; the code is right, so STFU already". *IF* counters.count_...
> is really little-endian 32bit, then why isn't it declared that way? And if
> it's host-endian, you've just papered over a real bug here.
>
> As a general rule "fix" doesn't mean "tell it to shut up"...
>
Thanks for the comments, I have updated but I have a mixed mind on the
__le32. I have to read more about it.
I would appreciate if you can comment again on the update.
next prev parent reply other threads:[~2019-11-11 13:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 23:38 [PATCH] staging: wfx: add gcc extension __force cast Jules Irenge
2019-11-09 8:36 ` Greg KH
2019-11-09 9:19 ` Al Viro
2019-11-11 13:51 ` Jules Irenge [this message]
2019-11-11 20:28 ` Al Viro
2019-11-11 23:16 ` Al Viro
2019-11-12 12:00 ` Jerome Pouiller
2019-11-12 11:32 ` Jerome Pouiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1911111347380.226731@ninjahub.org \
--to=jbi.octave@gmail.com \
--cc=Boqun.Feng@microsoft.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jerome.pouiller@silabs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).