From: Jules Irenge <jbi.octave@gmail.com>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: Jules Irenge <jbi.octave@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kasan-dev@googlegroups.com, akpm@linux-foundation.org,
dvyukov@google.com, glider@google.com, aryabinin@virtuozzo.com,
bsegall@google.com, rostedt@goodmis.org,
dietmar.eggemann@arm.com, vincent.guittot@linaro.org,
juri.lelli@redhat.com, peterz@infradead.org, mingo@redhat.com,
mgorman@suse.de, dvhart@infradead.org, tglx@linutronix.de,
namhyung@kernel.org, jolsa@redhat.com,
alexander.shishkin@linux.intel.com, mark.rutland@arm.com,
acme@kernel.org, viro@zeniv.linux.org.uk,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 00/11] Lock warning cleanup
Date: Mon, 10 Feb 2020 23:09:59 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.21.2002102306000.191510@ninjahub.org> (raw)
In-Reply-To: <20200210050622.GC69108@debian-boqun.qqnc3lrjykvubdpftowmye0fmh.lx.internal.cloudapp.net>
On Mon, 10 Feb 2020, Boqun Feng wrote:
> Hi Jules,
>
> On Sun, Feb 09, 2020 at 10:24:42PM +0000, Jules Irenge wrote:
> > This patch series adds missing annotations to functions that register warnings of context imbalance when built with Sparse tool.
> > The adds fix the warnings and give insight on what the functions are actually doing.
> >
> > 1. Within the futex subsystem, a __releases(&pi_state->.pi_mutex.wait_lock) is added because wake_futex_pi() only releases the lock at exit,
> > must_hold(q->lock_ptr) have been added to fixup_pi_state_owner() because the lock is held at entry and exit;
> > a __releases(&hb->lock) added to futex_wait_queue_me() as it only releases the lock.
> >
> > 2. Within fs_pin, a __releases(RCU) is added because the function exit RCU critical section at exit.
> >
> > 3. In kasan, an __acquires(&report_lock) has been added to start_report() and __releases(&report_lock) to end_report()
> >
> > 4. Within ring_buffer subsystem, a __releases(RCU) has been added perf_output_end()
> >
> > 5. schedule subsystem recorded an addition of the __releases(rq->lock) annotation and a __must_hold(this_rq->lock)
> >
> > 6. At hrtimer subsystem, __acquires(timer) is added to lock_hrtimer_base() as the function acquire the lock but never releases it.
> > Jules Irenge (11):
> > hrtimer: Add missing annotation to lock_hrtimer_base()
> > futex: Add missing annotation for wake_futex_pi()
> > futex: Add missing annotation for fixup_pi_state_owner()
>
> Given that those three patches have been sent and reviewed, please do
> increase the version number (this time, for example, using v2) when
> sending the updated ones. Also please add a few sentences after the
> commit log describing what you have changed between versions.
>
> Here is an example:
>
> https://lore.kernel.org/lkml/20200124231834.63628-4-pmalani@chromium.org/
>
> Regards,
> Boqun
>
> > perf/ring_buffer: Add missing annotation to perf_output_end()
> > sched/fair: Add missing annotation for nohz_newidle_balance()
> > sched/deadline: Add missing annotation for dl_task_offline_migration()
> > fs_pin: Add missing annotation for pin_kill() declaration
> > fs_pin: Add missing annotation for pin_kill() definition
> > kasan: add missing annotation for start_report()
> > kasan: add missing annotation for end_report()
> > futex: Add missing annotation for futex_wait_queue_me()
> >
> > fs/fs_pin.c | 2 +-
> > include/linux/fs_pin.h | 2 +-
> > kernel/events/ring_buffer.c | 2 +-
> > kernel/futex.c | 3 +++
> > kernel/sched/deadline.c | 1 +
> > kernel/sched/fair.c | 2 +-
> > kernel/time/hrtimer.c | 1 +
> > mm/kasan/report.c | 4 ++--
> > 8 files changed, 11 insertions(+), 6 deletions(-)
> >
> > --
> > 2.24.1
> >
>
Thanks for the feedback, I take good notes. I am working on the
second version.
Kind regards,
Jules
prev parent reply other threads:[~2020-02-10 23:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/11>
2020-02-09 22:24 ` [PATCH 00/11] Lock warning cleanup Jules Irenge
2020-02-09 22:27 ` [PATCH 01/11] hrtimer: Add missing annotation to lock_hrtimer_base() Jules Irenge
2020-02-09 22:29 ` [PATCH 02/11] futex: Add missing annotation for wake_futex_pi() Jules Irenge
2020-02-09 22:30 ` [PATCH 03/11] futex: Add missing annotation for fixup_pi_state_owner() Jules Irenge
2020-02-09 22:33 ` [PATCH 04/11] perf/ring_buffer: Add missing annotation to perf_output_end() Jules Irenge
2020-02-09 22:37 ` [PATCH 05/11] sched/fair: Add missing annotation for nohz_newidle_balance() Jules Irenge
2020-02-09 22:39 ` [PATCH 06/11] sched/deadline: Add missing annotation for dl_task_offline_migration() Jules Irenge
2020-02-10 8:07 ` Juri Lelli
2020-02-09 22:44 ` [PATCH 07/11] fs_pin: Add missing annotation for pin_kill() declaration Jules Irenge
2020-02-09 22:45 ` [PATCH 08/11] fs_pin: Add missing annotation for pin_kill() definition Jules Irenge
2020-02-09 22:48 ` [PATCH 09/11] kasan: add missing annotation for start_report() Jules Irenge
2020-02-10 7:27 ` Dmitry Vyukov
2020-02-09 22:49 ` [PATCH 10/11] kasan: add missing annotation for end_report() Jules Irenge
2020-02-10 7:27 ` Dmitry Vyukov
2020-02-09 22:50 ` [PATCH 11/11] futex: Add missing annotation for futex_wait_queue_me() Jules Irenge
2020-02-10 5:06 ` [PATCH 00/11] Lock warning cleanup Boqun Feng
2020-02-10 23:09 ` Jules Irenge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2002102306000.191510@ninjahub.org \
--to=jbi.octave@gmail.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=aryabinin@virtuozzo.com \
--cc=boqun.feng@gmail.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=dvhart@infradead.org \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=jolsa@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).