From: Jules Irenge <jbi.octave@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Jules Irenge <jbi.octave@gmail.com>,
linux-kernel@vger.kernel.org, julia.lawall@lip6.fr,
boqun.feng@gmail.com, Ingo Molnar <mingo@redhat.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2 4/4] locking/rtmutex: Remove Comparison to bool
Date: Fri, 3 Apr 2020 17:17:02 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.21.2004031716310.10601@earth.lan> (raw)
In-Reply-To: <20200330112157.GI20696@hirez.programming.kicks-ass.net>
On Mon, 30 Mar 2020, Peter Zijlstra wrote:
> On Mon, Mar 30, 2020 at 02:24:50AM +0100, Jules Irenge wrote:
>> Coccinelle reports a warning inside __sched rt_mutex_slowunlock()
>>
>> WARNING: Comparison to bool
>
> I don't mind the patch; but WTH is that a WARNING ?!? Superfluous, but
> definitely not wrong or even dangerous AFAICT.
>
>> To fix this,
>> a comparison (==) of a bool type function result to value true
>> together with the value are removed.
>>
>> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
>> ---
>> kernel/locking/rtmutex.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c
>> index 851bbb10819d..7289e7b26be4 100644
>> --- a/kernel/locking/rtmutex.c
>> +++ b/kernel/locking/rtmutex.c
>> @@ -1378,7 +1378,7 @@ static bool __sched rt_mutex_slowunlock(struct rt_mutex *lock,
>> */
>> while (!rt_mutex_has_waiters(lock)) {
>> /* Drops lock->wait_lock ! */
>> - if (unlock_rt_mutex_safe(lock, flags) == true)
>> + if (unlock_rt_mutex_safe(lock, flags))
>> return false;
>> /* Relock the rtmutex and try again */
>> raw_spin_lock_irqsave(&lock->wait_lock, flags);
>> --
>> 2.25.1
>>
>
Thanks for the reply, I will take good note.
next prev parent reply other threads:[~2020-04-03 16:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/4>
2020-03-30 1:24 ` [PATCH v2 0/4] Coccinelle cleanups Jules Irenge
2020-03-30 1:24 ` [PATCH v2 1/4] cpu: Remove Comparison to bool Jules Irenge
2020-03-30 1:24 ` [PATCH v2 2/4] rcu: Replace 1 by true Jules Irenge
2020-03-30 21:16 ` Paul E. McKenney
2020-03-30 1:24 ` [PATCH v2 3/4] genirq: " Jules Irenge
2020-03-30 1:24 ` [PATCH v2 4/4] locking/rtmutex: Remove Comparison to bool Jules Irenge
2020-03-30 11:21 ` Peter Zijlstra
2020-04-03 16:17 ` Jules Irenge [this message]
2020-08-01 18:45 ` [PATCH 0/4] Checkpatch tool errors clean up Jules Irenge
2020-08-01 18:46 ` [PATCH 1/4] acct: Add required space between variable and operator Jules Irenge
2020-08-01 18:46 ` [PATCH 2/4] audit: uninitialize global variable audit_sig_sid Jules Irenge
2020-08-01 18:55 ` Joe Perches
2020-08-01 20:26 ` Paul Moore
2020-08-02 14:32 ` Jules Irenge
2020-08-01 18:46 ` [PATCH 3/4] audit: uninitialize static variables Jules Irenge
2020-08-01 20:21 ` Paul Moore
2020-08-01 18:46 ` [PATCH 4/4] context_tracking: " Jules Irenge
2020-08-03 9:37 ` peterz
2020-08-03 10:27 ` Jules Irenge
2020-08-01 19:07 ` [PATCH 0/4] Checkpatch tool errors clean up Joe Perches
2020-08-02 14:54 ` Jules Irenge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2004031716310.10601@earth.lan \
--to=jbi.octave@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).