From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: linux-mips@vger.kernel.org, clang-built-linux@googlegroups.com,
Fangrui Song <maskray@google.com>,
Kees Cook <keescook@chromium.org>,
Nathan Chancellor <natechancellor@gmail.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Burton <paulburton@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Jouni Hogander <jouni.hogander@unikie.com>,
Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>,
Borislav Petkov <bp@suse.de>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] MIPS: Truncate link address into 32bit for 32bit kernel
Date: Fri, 24 Apr 2020 13:22:30 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.21.2004241316360.851719@eddie.linux-mips.org> (raw)
In-Reply-To: <B307BFAC-9973-4444-B69A-40B054210E84@flygoat.com>
On Thu, 23 Apr 2020, Jiaxun Yang wrote:
> > Alternatively, have you made any attempt to verify if actually replacing
> >the setting for VMLINUX_LOAD_ADDRESS would be safe? Glancing over its use
> >there do not appear to be many places.
>
> Limited experiments showed it should be fine...
>
> But MIPS kernel has some design I'm not really familiar with like SYM32 for
> 64-bit kernel and special address space design for Trap-and-emul KVM.
This only affects CONFIG_32BIT kernels, so SYM32 does not apply; I can't
comment on KVM. There's still that bunch of:
$(shell expr $(...) \< 0xffffffff80000000)
constructs I mentioned before, so let's leave your change as it stands at
this time. Please do rename the variable as I suggested though, I hope
that's not a big deal.
Maciej
next prev parent reply other threads:[~2020-05-13 22:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 6:26 [PATCH v4] MIPS: Truncate link address into 32bit for 32bit kernel Jiaxun Yang
2020-04-13 6:59 ` Maciej W. Rozycki
2020-04-13 7:32 ` Jiaxun Yang
2020-04-13 15:34 ` Fangrui Song
2020-04-13 20:08 ` Maciej W. Rozycki
2020-04-13 20:06 ` Maciej W. Rozycki
2020-04-13 16:25 ` Kees Cook
2020-04-13 18:52 ` Nathan Chancellor
2020-04-22 14:32 ` [PATCH v5] " Jiaxun Yang
2020-04-22 22:16 ` Nathan Chancellor
2020-04-23 0:10 ` Maciej W. Rozycki
2020-04-23 5:42 ` Jiaxun Yang
2020-04-24 12:22 ` Maciej W. Rozycki [this message]
2020-05-04 15:46 ` Thomas Bogendoerfer
2020-05-04 16:09 ` Jiaxun Yang
2020-05-04 16:56 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2004241316360.851719@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=bp@suse.de \
--cc=clang-built-linux@googlegroups.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jiaxun.yang@flygoat.com \
--cc=jouni.hogander@unikie.com \
--cc=keescook@chromium.org \
--cc=ldir@darbyshire-bryant.me.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=maskray@google.com \
--cc=natechancellor@gmail.com \
--cc=paulburton@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).