From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDA3CC433E2 for ; Mon, 31 Aug 2020 17:12:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A93FA20678 for ; Mon, 31 Aug 2020 17:12:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729004AbgHaRMW (ORCPT ); Mon, 31 Aug 2020 13:12:22 -0400 Received: from mg.ssi.bg ([178.16.128.9]:41756 "EHLO mg.ssi.bg" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727044AbgHaRMU (ORCPT ); Mon, 31 Aug 2020 13:12:20 -0400 Received: from mg.ssi.bg (localhost [127.0.0.1]) by mg.ssi.bg (Proxmox) with ESMTP id 1B84C247A0; Mon, 31 Aug 2020 20:12:17 +0300 (EEST) Received: from ink.ssi.bg (ink.ssi.bg [178.16.128.7]) by mg.ssi.bg (Proxmox) with ESMTP id 7A1112479F; Mon, 31 Aug 2020 20:12:16 +0300 (EEST) Received: from ja.ssi.bg (unknown [178.16.129.10]) by ink.ssi.bg (Postfix) with ESMTPS id DD17E3C24C7; Mon, 31 Aug 2020 20:12:09 +0300 (EEST) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by ja.ssi.bg (8.15.2/8.15.2) with ESMTP id 07VHC5NF006196; Mon, 31 Aug 2020 20:12:06 +0300 Date: Mon, 31 Aug 2020 20:12:05 +0300 (EEST) From: Julian Anastasov To: Yaroslav Bolyukin cc: "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Wensong Zhang , Simon Horman , Jakub Kicinski , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , netdev@vger.kernel.org, lvs-devel@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org Subject: Re: [PATCHv5 net-next] ipvs: remove dependency on ip6_tables In-Reply-To: <20200829135953.20228-1-iam@lach.pw> Message-ID: References: <20200829135953.20228-1-iam@lach.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Sat, 29 Aug 2020, Yaroslav Bolyukin wrote: > This dependency was added because ipv6_find_hdr was in iptables specific > code but is no longer required > > Fixes: f8f626754ebe ("ipv6: Move ipv6_find_hdr() out of Netfilter code.") > Fixes: 63dca2c0b0e7 ("ipvs: Fix faulty IPv6 extension header handling in IPVS"). > Signed-off-by: Yaroslav Bolyukin Looks good to me, thanks! May be maintainers will remove the extra dot after the Fixes line. Acked-by: Julian Anastasov > --- > Missed canonical patch format section, subsystem is now spevified > > include/net/ip_vs.h | 3 --- > net/netfilter/ipvs/Kconfig | 1 - > 2 files changed, 4 deletions(-) > > diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h > index 9a59a3378..d609e957a 100644 > --- a/include/net/ip_vs.h > +++ b/include/net/ip_vs.h > @@ -25,9 +25,6 @@ > #include > #include /* for struct ipv6hdr */ > #include > -#if IS_ENABLED(CONFIG_IP_VS_IPV6) > -#include > -#endif > #if IS_ENABLED(CONFIG_NF_CONNTRACK) > #include > #endif > diff --git a/net/netfilter/ipvs/Kconfig b/net/netfilter/ipvs/Kconfig > index 2c1593089..eb0e329f9 100644 > --- a/net/netfilter/ipvs/Kconfig > +++ b/net/netfilter/ipvs/Kconfig > @@ -29,7 +29,6 @@ if IP_VS > config IP_VS_IPV6 > bool "IPv6 support for IPVS" > depends on IPV6 = y || IP_VS = IPV6 > - select IP6_NF_IPTABLES > select NF_DEFRAG_IPV6 > help > Add IPv6 support to IPVS. > -- > 2.28.0 Regards -- Julian Anastasov