From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754283Ab2J1Smc (ORCPT <rfc822;w@1wt.eu>);
	Sun, 28 Oct 2012 14:42:32 -0400
Received: from 1010ds2-suoe.0.fullrate.dk ([90.184.90.115]:11173 "EHLO
	swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754260Ab2J1Sma (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 28 Oct 2012 14:42:30 -0400
Date: Tue, 25 Nov 2008 14:42:09 +0100 (CET)
From: Jesper Juhl <jj@chaosbits.net>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Len Brown <lenb@kernel.org>, Lin Ming <ming.m.lin@intel.com>,
        Bob Moore <robert.moore@intel.com>
Subject: Re: [PATCH] ACPICA: Don't leak next_walk_state in
 acpi_ds_call_control_method()
In-Reply-To: <2295104.eQ6lcDpNzT@vostro.rjw.lan>
Message-ID: <alpine.LNX.2.00.0811251440440.1109@swampdragon.chaosbits.net>
References: <alpine.LNX.2.00.1210212233180.26319@swampdragon.chaosbits.net> <2295104.eQ6lcDpNzT@vostro.rjw.lan>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 25 Oct 2012, Rafael J. Wysocki wrote:

> On Sunday 21 of October 2012 22:35:46 Jesper Juhl wrote:
> > If acpi_ds_create_walk_state() succeeds, but the call to
> > ACPI_ALLOCATE_ZEROED() fails, then we'll return from the function
> > without properly freeing 'next_walk_state'.
> > 
> > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> 
> This has to go through ACPICA upstream, but we'll get it from there eventually.
> 

Ok. I haven't heard any response to this other than yours, so I guess I'll 
just re-send it in a few days if I still hear nothing.

Can I add your ACK when I re-send?

/Jesper


> Thanks,
> Rafael
> 
> 
> > ---
> >  drivers/acpi/acpica/dsmethod.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/acpi/acpica/dsmethod.c b/drivers/acpi/acpica/dsmethod.c
> > index aa9a5d4..ade59a3 100644
> > --- a/drivers/acpi/acpica/dsmethod.c
> > +++ b/drivers/acpi/acpica/dsmethod.c
> > @@ -378,7 +378,8 @@ acpi_ds_call_control_method(struct acpi_thread_state *thread,
> >  	 */
> >  	info = ACPI_ALLOCATE_ZEROED(sizeof(struct acpi_evaluate_info));
> >  	if (!info) {
> > -		return_ACPI_STATUS(AE_NO_MEMORY);
> > +		status = AE_NO_MEMORY;
> > +		goto cleanup;
> >  	}
> >  
> >  	info->parameters = &this_walk_state->operands[0];
> > 
> 

-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.