From: Jesper Juhl <jj@chaosbits.net>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Len Brown <len.brown@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] thermal_sys: Remove unnecessary line continuations
Date: Wed, 25 Jan 2012 00:41:36 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1201250040420.27508@swampdragon.chaosbits.net> (raw)
In-Reply-To: <4afc2738bbc7690440312921d8ae8ddf0e14e2dc.1327447797.git.joe@perches.com>
On Tue, 24 Jan 2012, Joe Perches wrote:
> Line continations are not necessary in function calls
> or statements. Remove them.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/thermal/thermal_sys.c | 11 +++++------
> 1 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> index dd9a574..7326baa 100644
> --- a/drivers/thermal/thermal_sys.c
> +++ b/drivers/thermal/thermal_sys.c
> @@ -283,8 +283,7 @@ passive_show(struct device *dev, struct device_attribute *attr,
> static DEVICE_ATTR(type, 0444, type_show, NULL);
> static DEVICE_ATTR(temp, 0444, temp_show, NULL);
> static DEVICE_ATTR(mode, 0644, mode_show, mode_store);
> -static DEVICE_ATTR(passive, S_IRUGO | S_IWUSR, passive_show, \
> - passive_store);
> +static DEVICE_ATTR(passive, S_IRUGO | S_IWUSR, passive_show, passive_store);
>
> static struct device_attribute trip_point_attrs[] = {
> __ATTR(trip_point_0_type, 0444, trip_point_type_show, NULL),
> @@ -1314,8 +1313,8 @@ int generate_netlink_event(u32 orig, enum events event)
> int result;
>
> /* allocate memory */
> - size = nla_total_size(sizeof(struct thermal_genl_event)) + \
> - nla_total_size(0);
> + size = nla_total_size(sizeof(struct thermal_genl_event)) +
> + nla_total_size(0);
>
> skb = genlmsg_new(size, GFP_ATOMIC);
> if (!skb)
> @@ -1331,8 +1330,8 @@ int generate_netlink_event(u32 orig, enum events event)
> }
>
> /* fill the data */
> - attr = nla_reserve(skb, THERMAL_GENL_ATTR_EVENT, \
> - sizeof(struct thermal_genl_event));
> + attr = nla_reserve(skb, THERMAL_GENL_ATTR_EVENT,
> + sizeof(struct thermal_genl_event));
>
> if (!attr) {
> nlmsg_free(skb);
>
Yes.
Reviewed-by: Jesper Juhl <jj@chaosbits.net>
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
next prev parent reply other threads:[~2012-01-24 23:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 23:35 [PATCH 0/4] thermal_sys: Cleanups Joe Perches
2012-01-24 23:35 ` [PATCH 1/4] thermal_sys: Remove unnecessary line continuations Joe Perches
2012-01-24 23:41 ` Jesper Juhl [this message]
2012-01-24 23:35 ` [PATCH 2/4] thermal_sys: Remove obfuscating used-once macros Joe Perches
2012-01-26 23:31 ` Andrew Morton
2012-01-24 23:35 ` [PATCH 3/4] thermal_sys: Kernel style cleanups Joe Perches
2012-01-24 23:39 ` Jesper Juhl
2012-01-24 23:35 ` [PATCH 4/4] thermal_sys: Convert printks to pr_<level> Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1201250040420.27508@swampdragon.chaosbits.net \
--to=jj@chaosbits.net \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).