From: Jiri Kosina <jkosina@suse.cz>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg KH <greg@kroah.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Dominik Brodowski <linux@dominikbrodowski.net>,
linux-input@vger.kernel.org, linux-pci@vger.kernel.org,
linux-pcmcia@lists.infradead.org,
USB list <linux-usb@vger.kernel.org>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] Dynamic ID addition doesn't need get_driver()
Date: Wed, 1 Feb 2012 14:15:45 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1202011415250.18918@pobox.suse.cz> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1201241310400.1200-100000@iolanthe.rowland.org>
On Tue, 24 Jan 2012, Alan Stern wrote:
> As part of the removal of get_driver()/put_driver(), this patch
> (as1511) changes all the places that add dynamic IDs for drivers.
> Since these additions are done by writing to the drivers' sysfs
> attribute files, and the attributes are removed when the drivers are
> unregistered, there is no reason to take an extra reference to the
> drivers.
>
> The one exception is the pci-stub driver, which calls pci_add_dynid()
> as part of its registration. But again, there's no reason to take an
> extra reference here, because the driver can't be unloaded while it is
> being registered.
>
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> CC: Jiri Kosina <jkosina@suse.cz>
> CC: Jesse Barnes <jbarnes@virtuousgeek.org>
> CC: Dominik Brodowski <linux@dominikbrodowski.net>
Acked-by: Jiri Kosina <jkosina@suse.cz>
for the drivers/hid part. Thanks,
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2012-02-01 13:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 18:34 [PATCH 2/5] Dynamic ID addition doesn't need get_driver() Alan Stern
2012-01-25 19:33 ` Dominik Brodowski
2012-01-27 18:40 ` Jesse Barnes
2012-02-01 13:15 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1202011415250.18918@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=dmitry.torokhov@gmail.com \
--cc=greg@kroah.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).