linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Kosina <jkosina@suse.cz>
To: Josh Triplett <josh@joshtriplett.org>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] hid: Remove "default m" from HID_LOGITECH_DJ
Date: Mon, 3 Sep 2012 14:49:42 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LNX.2.00.1209031449140.20709@pobox.suse.cz> (raw)
In-Reply-To: <20120903044351.GA1590@leaf>

On Sun, 2 Sep 2012, Josh Triplett wrote:

> HID_LOGITECH_DJ uses "default m", which enables it in default kernel
> builds.  Since this module just enables extra, non-critical
> functionality for one particular piece of hardware (specifically,
> differentiating multiple wireless keyboards and mice as separate input
> devices rather than treating them as one device), and the hardware works
> just fine with the default USB HID support, drop the "default m".
> 
> Signed-off-by: Josh Triplett <josh@joshtriplett.org>
> ---
>  drivers/hid/Kconfig |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index fbf4950..d004528 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -307,7 +307,6 @@ config HID_LOGITECH
>  config HID_LOGITECH_DJ
>  	tristate "Logitech Unifying receivers full support"
>  	depends on HID_LOGITECH
> -	default m
>  	---help---
>  	Say Y if you want support for Logitech Unifying receivers and devices.
>  	Unifying receivers are capable of pairing up to 6 Logitech compliant

That was an overlook on my side when merging the driver. Applied, thanks.

-- 
Jiri Kosina
SUSE Labs

      reply	other threads:[~2012-09-03 12:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-03  4:43 Josh Triplett
2012-09-03 12:49 ` Jiri Kosina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1209031449140.20709@pobox.suse.cz \
    --to=jkosina@suse.cz \
    --cc=josh@joshtriplett.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH] hid: Remove "default m" from HID_LOGITECH_DJ' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).