linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] hid: Remove "default m" from HID_LOGITECH_DJ
@ 2012-09-03  4:43 Josh Triplett
  2012-09-03 12:49 ` Jiri Kosina
  0 siblings, 1 reply; 2+ messages in thread
From: Josh Triplett @ 2012-09-03  4:43 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-input, Jiri Kosina, Linus Torvalds

HID_LOGITECH_DJ uses "default m", which enables it in default kernel
builds.  Since this module just enables extra, non-critical
functionality for one particular piece of hardware (specifically,
differentiating multiple wireless keyboards and mice as separate input
devices rather than treating them as one device), and the hardware works
just fine with the default USB HID support, drop the "default m".

Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/hid/Kconfig |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index fbf4950..d004528 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -307,7 +307,6 @@ config HID_LOGITECH
 config HID_LOGITECH_DJ
 	tristate "Logitech Unifying receivers full support"
 	depends on HID_LOGITECH
-	default m
 	---help---
 	Say Y if you want support for Logitech Unifying receivers and devices.
 	Unifying receivers are capable of pairing up to 6 Logitech compliant
-- 
1.7.10.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] hid: Remove "default m" from HID_LOGITECH_DJ
  2012-09-03  4:43 [PATCH] hid: Remove "default m" from HID_LOGITECH_DJ Josh Triplett
@ 2012-09-03 12:49 ` Jiri Kosina
  0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2012-09-03 12:49 UTC (permalink / raw)
  To: Josh Triplett; +Cc: linux-kernel, linux-input, Linus Torvalds

On Sun, 2 Sep 2012, Josh Triplett wrote:

> HID_LOGITECH_DJ uses "default m", which enables it in default kernel
> builds.  Since this module just enables extra, non-critical
> functionality for one particular piece of hardware (specifically,
> differentiating multiple wireless keyboards and mice as separate input
> devices rather than treating them as one device), and the hardware works
> just fine with the default USB HID support, drop the "default m".
> 
> Signed-off-by: Josh Triplett <josh@joshtriplett.org>
> ---
>  drivers/hid/Kconfig |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index fbf4950..d004528 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -307,7 +307,6 @@ config HID_LOGITECH
>  config HID_LOGITECH_DJ
>  	tristate "Logitech Unifying receivers full support"
>  	depends on HID_LOGITECH
> -	default m
>  	---help---
>  	Say Y if you want support for Logitech Unifying receivers and devices.
>  	Unifying receivers are capable of pairing up to 6 Logitech compliant

That was an overlook on my side when merging the driver. Applied, thanks.

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-03 12:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-03  4:43 [PATCH] hid: Remove "default m" from HID_LOGITECH_DJ Josh Triplett
2012-09-03 12:49 ` Jiri Kosina

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).