From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757519Ab2IEI5H (ORCPT ); Wed, 5 Sep 2012 04:57:07 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50982 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751298Ab2IEI5F (ORCPT ); Wed, 5 Sep 2012 04:57:05 -0400 Date: Wed, 5 Sep 2012 10:56:53 +0200 (CEST) From: Jiri Kosina To: Benjamin Herrenschmidt Cc: Andreas Schwab , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] powerpc: fix personality handling in ppc64_personality() In-Reply-To: <1346813643.2257.24.camel@pasglop> Message-ID: References: <1346813643.2257.24.camel@pasglop> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 5 Sep 2012, Benjamin Herrenschmidt wrote: > > Directly comparing current->personality against PER_LINUX32 doesn't work > > in cases when any of the personality flags stored in the top three bytes > > are used. > > > > Directly forcefully setting personality to PER_LINUX32 or PER_LINUX > > discards any flags stored in the top three bytes > > > > Use personality() macro to compare only PER_MASK bytes and make sure that > > we are setting only the bits that should be set, instead of > > overwriting the whole value. > > > > Signed-off-by: Jiri Kosina > > --- > > > > changed since v1: fix the bit ops to reflect the fact that PER_LINUX is > > actually 0 > > Had already merged v1 (oops.. didn't spot the issue with PER_LINUX being > 0). Can you send an incremental fixup ? Hi Benjamin, actually commit 7256a5d2da56 seems to contain the correct PER_LINUX handling, so seems like you picked the right one :) Thanks, -- Jiri Kosina SUSE Labs