From: Jiri Kosina <jkosina@suse.cz>
To: Axel Lin <axel.lin@gmail.com>
Cc: Chris Schlund <chrisschlund@gmx.de>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: hid-lcpower: Use HID_UP_LOGIVENDOR instead of hard coded 0x0ffbc0000
Date: Wed, 5 Sep 2012 11:57:36 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1209051156560.11079@pobox.suse.cz> (raw)
In-Reply-To: <1346811570.3994.0.camel@phoenix>
On Wed, 5 Sep 2012, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/hid/hid-lcpower.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-lcpower.c b/drivers/hid/hid-lcpower.c
> index c4fe9bd0..22bc14a 100644
> --- a/drivers/hid/hid-lcpower.c
> +++ b/drivers/hid/hid-lcpower.c
> @@ -24,7 +24,7 @@ static int ts_input_mapping(struct hid_device *hdev, struct hid_input *hi,
> struct hid_field *field, struct hid_usage *usage,
> unsigned long **bit, int *max)
> {
> - if ((usage->hid & HID_USAGE_PAGE) != 0x0ffbc0000)
> + if ((usage->hid & HID_USAGE_PAGE) != HID_UP_LOGIVENDOR)
> return 0;
>
> switch (usage->hid & HID_USAGE) {
The name of the actual constant is quite losing its point with more and
more non-Logitech devices using this usage page.
I am applying your patch now, but I guess we'll rather rename the define
in a near future.
Thanks,
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2012-09-05 9:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 2:19 [PATCH] HID: hid-lcpower: Use HID_UP_LOGIVENDOR instead of hard coded 0x0ffbc0000 Axel Lin
2012-09-05 9:57 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1209051156560.11079@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=axel.lin@gmail.com \
--cc=chrisschlund@gmx.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).