From: Hugh Dickins <hughd@google.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Wen Congyang <wency@cn.fujitsu.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, Jiang Liu <liuj97@gmail.com>,
bsingharora@gmail.com,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
paul.gortmaker@windriver.com, Tang Chen <tangchen@cn.fujitsu.com>
Subject: Re: [PATCH] memcg: fix hotplugged memory zone oops
Date: Fri, 2 Nov 2012 16:31:18 -0700 (PDT) [thread overview]
Message-ID: <alpine.LNX.2.00.1211021626150.11106@eggly.anvils> (raw)
In-Reply-To: <20121102102159.GA24073@dhcp22.suse.cz>
On Fri, 2 Nov 2012, Michal Hocko wrote:
>
> OK, it adds "an overhead" also when there is no hotadd going on but this
> is just one additional mem access&cmp&je so it shouldn't be noticable
> (lruvec->zone is used most of the time later so it not a pointless
> load).
I think so too.
> It is also easier to backport for stable.
Yes.
> But is there any reason to fix it later properly in the hotadd hook?
I don't know. Not everybody liked it fixed this way: it's not
unreasonable to see this as a quick hack rather than the right fix.
I was expecting objectors to post alternative hotadd hook patches,
then we could compare and decide. That didn't happen; but we can
certainly look to taking out these lines later if something we
agree is better comes along. Not high on anyone's agenda, I think.
>
> Anyway
> Acked-by: Michal Hocko <mhocko@suse.cz>
Thanks,
Hugh
next prev parent reply other threads:[~2012-11-02 23:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 7:14 [PATCH] memory cgroup: update root memory cgroup when node is onlined Wen Congyang
2012-09-13 10:06 ` Kamezawa Hiroyuki
2012-09-13 10:18 ` Wen Congyang
2012-09-13 20:59 ` Johannes Weiner
2012-09-14 1:36 ` Hugh Dickins
2012-09-14 1:53 ` Wen Congyang
2012-09-14 15:46 ` Johannes Weiner
2012-09-15 10:56 ` Konstantin Khlebnikov
2012-09-17 5:50 ` Wen Congyang
2012-10-16 5:58 ` Wen Congyang
2012-10-18 19:03 ` Hugh Dickins
2012-10-18 22:03 ` Johannes Weiner
2012-11-02 1:28 ` [PATCH] memcg: fix hotplugged memory zone oops Hugh Dickins
2012-11-02 10:21 ` Michal Hocko
2012-11-02 10:54 ` Michal Hocko
2012-11-02 23:37 ` Hugh Dickins
2012-11-03 7:00 ` Michal Hocko
2012-11-02 23:31 ` Hugh Dickins [this message]
2012-10-16 7:21 ` [PATCH] memory cgroup: update root memory cgroup when node is onlined Kamezawa Hiroyuki
2012-09-14 1:46 ` Wen Congyang
2012-09-17 6:40 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1211021626150.11106@eggly.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuj97@gmail.com \
--cc=mhocko@suse.cz \
--cc=paul.gortmaker@windriver.com \
--cc=tangchen@cn.fujitsu.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).