From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753567Ab2KLOnf (ORCPT ); Mon, 12 Nov 2012 09:43:35 -0500 Received: from cantor2.suse.de ([195.135.220.15]:39699 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753111Ab2KLOnc (ORCPT ); Mon, 12 Nov 2012 09:43:32 -0500 Date: Mon, 12 Nov 2012 15:43:29 +0100 (CET) From: Jiri Kosina To: Sasha Levin Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] alpha: use BUG_ON where possible In-Reply-To: <509D2DF8.4030602@oracle.com> Message-ID: References: <1352406191-14303-1-git-send-email-sasha.levin@oracle.com> <1352406191-14303-2-git-send-email-sasha.levin@oracle.com> <509D2DF8.4030602@oracle.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Nov 2012, Sasha Levin wrote: > >> Just use BUG_ON() instead of constructions such as: > >> > >> if (...) > >> BUG() > >> > >> A simplified version of the semantic patch that makes this transformation > >> is as follows: (http://coccinelle.lip6.fr/) > >> > >> // > >> @@ > >> expression e; > >> @@ > >> - if (e) BUG(); > >> + BUG_ON(e); > > > > Ok, I guess I am just going to apply this one. Thanks, > > > > So I have about 80 more of these. I've sent out the first 10 to make sure > that they look fine and the only complaints I got about them are that they are > trivial :) > > Can I send the rest directly to you to go through the trivial tree? How many conflict can you see if you generate this patch on top of Linus' tree and thn apply it to linux-next? -- Jiri Kosina SUSE Labs