From: Jiri Kosina <jkosina@suse.cz>
To: David Barksdale <dbarksdale@uplogix.com>
Cc: "David Herrmann" <dh.herrmann@gmail.com>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Oliver Neukum" <oliver@neukum.org>,
"Jakub Kákona" <kjakub@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] HID: New hid-cp2112 driver
Date: Fri, 31 Jan 2014 11:41:17 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1401311138400.27155@pobox.suse.cz> (raw)
In-Reply-To: <1391037975-26253-1-git-send-email-dbarksdale@uplogix.com>
On Wed, 29 Jan 2014, David Barksdale wrote:
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 34e2d39..246a233 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -175,6 +175,15 @@ config HID_PRODIKEYS
> multimedia keyboard, but will lack support for the musical keyboard
> and some additional multimedia keys.
>
> +config HID_CP2112
> + tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support"
> + depends on USB_HID
Dependency on I2C is necessary as well, isn't it?
Other than that, it looks good to me.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2014-01-31 10:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 23:26 [PATCH v4] HID: New hid-cp2112 driver David Barksdale
2014-01-29 23:46 ` Joe Perches
2014-01-30 7:35 ` Oliver Neukum
2014-01-30 9:52 ` Joe Perches
2014-01-30 12:49 ` Oliver Neukum
2014-01-31 10:41 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1401311138400.27155@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=benjamin.tissoires@redhat.com \
--cc=dbarksdale@uplogix.com \
--cc=dh.herrmann@gmail.com \
--cc=kjakub@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).