From: Jiri Kosina <jkosina@suse.cz>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Dave Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
DRI mailing list <dri-devel@lists.freedesktop.org>
Subject: Re: [git pull] drm next tree
Date: Fri, 7 Feb 2014 14:40:48 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1402071437400.24838@pobox.suse.cz> (raw)
In-Reply-To: <87a9e318m6.fsf@intel.com>
On Fri, 7 Feb 2014, Jani Nikula wrote:
> >> > git://people.freedesktop.org/~airlied/linux drm-next
> >> [ ... snip ... ]
> >> > Daniel Vetter (59):
> >> [ ... snip ... ]
> >> > drm/i915: dp aux irq support for g4x/vlv
> >>
> >> This commit causes all kinds of havoc on my ThinkPad x200s. It results in
> > [ ... snip ... ]
> >
> > Not having received any response, I suggest the following for 3.14
>
> Daniel, it's your commit this bisects to...
>
> If we end up having to revert, I'd just touch the has_aux_irq part, for
> example:
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 5ede4e8..464c047 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -404,7 +404,7 @@ intel_dp_aux_ch(struct intel_dp *intel_dp,
> int i, ret, recv_bytes;
> uint32_t status;
> int try, precharge, clock = 0;
> - bool has_aux_irq = true;
> + bool has_aux_irq = INTEL_INFO(dev)->gen >= 5;
> uint32_t timeout;
>
> /* dp aux is extremely sensitive to irq latency, hence request the
That, obviously, works for my system as well. Feel free to add
Reported-and-tested-by: Jiri Kosina <jkosina@suse.cz>
if you are going with this instead of the revert.
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2014-02-07 13:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 2:49 [git pull] drm next tree Dave Airlie
2014-01-30 4:54 ` Linus Torvalds
2014-01-30 12:33 ` Paul Bolle
2014-02-20 21:02 ` [PATCH] drm/radeon: silence GCC warning on 32 bit Paul Bolle
2014-02-20 21:07 ` Ilia Mirkin
2014-02-20 21:24 ` Paul Bolle
2014-02-21 8:20 ` Thierry Reding
2014-03-04 9:34 ` [PATCH v2] " Paul Bolle
2014-03-04 11:42 ` Christian König
2014-03-04 14:52 ` Alex Deucher
2014-01-30 15:55 ` [git pull] drm next tree Jiri Kosina
2014-02-07 10:08 ` Jiri Kosina
2014-02-07 11:10 ` Jani Nikula
2014-02-07 13:40 ` Jiri Kosina [this message]
2014-02-07 14:05 ` Daniel Vetter
2014-02-07 14:15 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2011-03-17 4:09 Dave Airlie
2011-03-23 2:19 ` Linus Torvalds
2011-03-23 12:21 ` Stephen Clark
2011-03-23 14:39 ` Jerome Glisse
2011-03-23 15:22 ` Jesse Barnes
2011-03-23 14:22 ` Alessandro Suardi
2011-03-23 15:29 ` Linus Torvalds
2011-03-23 15:33 ` Jesse Barnes
2011-03-24 0:54 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1402071437400.24838@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).