From: Jiri Kosina <jkosina@suse.cz>
To: Or Gerlitz <or.gerlitz@gmail.com>
Cc: Roland Dreier <roland@kernel.org>,
Amir Vadai <amirv@mellanox.com>,
Eli Cohen <eli@dev.mellanox.co.il>,
Or Gerlitz <ogerlitz@mellanox.com>,
Eugenia Emantayev <eugenia@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
Mel Gorman <mgorman@suse.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mlx4: Use GFP_NOFS calls during the ipoib TX path when creating the QP
Date: Tue, 25 Feb 2014 23:40:35 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1402252338480.5180@pobox.suse.cz> (raw)
In-Reply-To: <CAJZOPZJpRYKw7Dskr21QP_d6c7ySS+mi-g_19pNJYm0Gq=ZY+g@mail.gmail.com>
On Wed, 26 Feb 2014, Or Gerlitz wrote:
> >> And what happens if you use IPoIB datagram mode, is/why the patch is
> >> needed there?
>
> > I admittedly am no infiniband expert, but my understanding is that in
> > principle Connected/Datagram mode is about MTU and checksum offloading,
>
> yes, the differences between the mode relate to these aspects, however
Thanks for confirming.
> > but the TX path is the same. Please correct me if I am wrong.
>
> no, note that your patch only touched drivers/infiniband/ulp/ipoib/ipoib_cm.c
> which is basically compiled out if you set CONFIG_INFINIBAND_IPOIB_CM,
> so surely the TX path for the datagram vs. connected modes are
> different.
Yes, but for datagram mode, the tx_ring is allocated in a completely
different way (not from kworker), so this might be a non-issue, right? I
will have to look into it more deeply to be really sure; if you can
provide your insight, that'd be helpful.
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2014-02-25 22:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 21:53 [PATCH] mlx4: Use GFP_NOFS calls during the ipoib TX path when creating the QP Jiri Kosina
[not found] ` <CAJZOPZK4Ah+nKPWnX3=yM43jbf586GYJ+fh0-OL4bOnqKK8v8A@mail.gmail.com>
2014-02-25 21:52 ` Or Gerlitz
2014-02-25 22:11 ` Jiri Kosina
2014-02-25 22:20 ` Or Gerlitz
2014-02-25 22:40 ` Jiri Kosina [this message]
2014-02-25 22:48 ` Or Gerlitz
2014-02-25 22:55 ` Jiri Kosina
2014-03-05 19:46 ` Or Gerlitz
2014-03-06 13:31 ` Or Gerlitz
2014-03-06 13:47 ` Jiri Kosina
2014-02-26 21:18 Or Gerlitz
2014-02-27 9:48 ` Jiri Kosina
2014-02-27 9:58 ` Or Gerlitz
2014-02-27 10:42 ` Jiri Kosina
2014-03-04 22:48 ` Jiri Kosina
2014-03-05 15:57 ` Or Gerlitz
2014-03-05 19:25 ` Roland Dreier
2014-03-11 13:53 ` Or Gerlitz
2014-03-14 19:50 ` Jiri Kosina
2014-04-24 17:03 ` Jiri Kosina
2014-04-24 20:01 ` Or Gerlitz
2014-05-02 13:03 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1402252338480.5180@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=eli@dev.mellanox.co.il \
--cc=eugenia@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=or.gerlitz@gmail.com \
--cc=roland@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).