From: Jiri Kosina <jkosina@suse.cz>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Ben Hawkes <hawkes@google.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [GIT PULL] HID
Date: Fri, 22 Aug 2014 03:00:06 -0500 (CDT) [thread overview]
Message-ID: <alpine.LNX.2.00.1408220257050.23162@pobox.suse.cz> (raw)
In-Reply-To: <20140822074030.GA297@x4>
On Fri, 22 Aug 2014, Markus Trippelsdorf wrote:
> > HID: logitech: perform bounds checking on device_id early enough
>
> The commit above (ad3e14d7c5268c2e) causes the bounds checking to always
> fail on my monolithic kernel (without modules):
>
> ...
> [ 2.922617] usb 4-2: new full-speed USB device number 2 using ohci-pci
> [ 2.996587] udevd[98]: starting eudev version 1.0
> [ 3.071203] random: nonblocking pool is initialized
> [ 3.108360] logitech-djreceiver 0003:046D:C52B.0003: hiddev0,hidraw0: USB HID v1.11 Device [Logitech USB Receiver] on usb-0000:00:12.1-2/input2
> [ 3.163208] input: Logitech Unifying Device. Wireless PID:4026 as /devices/pci0000:00/0000:00:12.1/usb4/4-2/4-2:1.2/0003:046D:C52B.0003/0003:046D:C52B.0004/input/input2
> [ 3.163511] logitech-djdevice 0003:046D:C52B.0004: input,hidraw1: USB HID v1.11 Keyboard [Logitech Unifying Device. Wireless PID:4026] on usb-0000:00:12.1-2:1
> [ 3.164121] logitech-djreceiver 0003:046D:C52B.0003: logi_dj_raw_event: invalid device index:0
> [ 3.289261] usb 3-1: new low-speed USB device number 2 using ohci-pci
> [ 3.457606] input: HID 046a:0011 as /devices/pci0000:00/0000:00:12.0/usb3/3-1/3-1:1.0/0003:046A:0011.0005/input/input3
> [ 3.457794] hid-generic 0003:046A:0011.0005: input,hidraw2: USB HID v1.10 Keyboard [HID 046a:0011] on usb-0000:00:12.0-1/input0
> [ 3.712886] Switched to clocksource tsc
Thanks a lot for a timely report.
I am travelling till next week and don't unfortunately have the hardware
here with me to test momentarily, so please take this with a lot of grains
of salt (maybe Benjamin would be able to look into this before I'd be able
to on monday ... ?).
Does the shot-in-the-dakr patch below put things back in shape for you?
diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
index b7ba829..d9ae77f 100644
--- a/drivers/hid/hid-logitech-dj.c
+++ b/drivers/hid/hid-logitech-dj.c
@@ -861,7 +861,7 @@ static void logi_dj_remove(struct hid_device *hdev)
* have finished and no more raw_event callbacks should arrive after
* the remove callback was triggered so no locks are put around the
* code below */
- for (i = 0; i < (DJ_MAX_PAIRED_DEVICES + DJ_DEVICE_INDEX_MIN); i++) {
+ for (i = 0; i < (DJ_MAX_PAIRED_DEVICES + DJ_DEVICE_INDEX_MIN + 1); i++) {
dj_dev = djrcv_dev->paired_dj_devices[i];
if (dj_dev != NULL) {
hid_destroy_device(dj_dev->hdev);
diff --git a/drivers/hid/hid-logitech-dj.h b/drivers/hid/hid-logitech-dj.h
index 4a40003..1f630e4 100644
--- a/drivers/hid/hid-logitech-dj.h
+++ b/drivers/hid/hid-logitech-dj.h
@@ -27,8 +27,8 @@
#define DJ_MAX_PAIRED_DEVICES 6
#define DJ_MAX_NUMBER_NOTIFICATIONS 8
-#define DJ_DEVICE_INDEX_MIN 1
-#define DJ_DEVICE_INDEX_MAX 6
+#define DJ_DEVICE_INDEX_MIN 0
+#define DJ_DEVICE_INDEX_MAX 5
#define DJREPORT_SHORT_LENGTH 15
#define DJREPORT_LONG_LENGTH 32
@@ -97,7 +97,7 @@ struct dj_report {
struct dj_receiver_dev {
struct hid_device *hdev;
struct dj_device *paired_dj_devices[DJ_MAX_PAIRED_DEVICES +
- DJ_DEVICE_INDEX_MIN];
+ DJ_DEVICE_INDEX_MIN + 1];
struct work_struct work;
struct kfifo notif_fifo;
spinlock_t lock;
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2014-08-22 8:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 17:43 [GIT PULL] HID Jiri Kosina
2014-08-22 7:40 ` Markus Trippelsdorf
2014-08-22 8:00 ` Jiri Kosina [this message]
2014-08-22 8:18 ` Markus Trippelsdorf
2014-08-22 14:25 ` Benjamin Tissoires
-- strict thread matches above, loose matches on Subject: below --
2018-08-20 16:23 Jiri Kosina
2018-06-08 8:36 Jiri Kosina
2018-01-31 15:48 Jiri Kosina
2017-12-30 11:19 Jiri Kosina
2017-01-11 21:48 Jiri Kosina
2016-05-03 10:42 Jiri Kosina
2015-08-10 22:13 Jiri Kosina
2015-07-24 13:21 Jiri Kosina
2015-01-09 14:43 Jiri Kosina
2014-12-12 10:42 Jiri Kosina
2014-11-13 20:06 Jiri Kosina
2014-10-29 14:01 Jiri Kosina
2014-08-27 7:23 Jiri Kosina
2014-07-07 14:01 Jiri Kosina
2014-05-07 12:54 Jiri Kosina
2014-04-18 13:26 Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1408220257050.23162@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=benjamin.tissoires@redhat.com \
--cc=hawkes@google.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).