linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Kosina <jkosina@suse.cz>
To: Huang Bo <huangbobupt@163.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 1/1] HID: add BETOP game controller force feedback support
Date: Mon, 1 Dec 2014 21:11:51 +0100 (CET)	[thread overview]
Message-ID: <alpine.LNX.2.00.1412012111020.2524@pobox.suse.cz> (raw)
In-Reply-To: <5477CDD4.8000908@163.com>

On Fri, 28 Nov 2014, Huang Bo wrote:

> On 11/27/2014 05:05 PM, Jiri Kosina wrote:
> > except ...
> thanks firstly.
> 1. tested the BETOP2185 gamecontroller, it really not need it.
> 2. check with engineers of Betop, they design only one report descriptor.
> 
> so I modify it.

Thanks, but please put the comment into the code (jus before you are 
zeroing the fields), so that it's immediately obvious to everybody who is 
reading the code.

Other than that, I am OK with the patch and will be applying it once you 
resend it with the comments added.

Thanks,

-- 
Jiri Kosina
SUSE Labs

  reply	other threads:[~2014-12-01 20:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27  1:46 [PATCHv3 1/1] HID: add BETOP game controller force feedback support Huang Bo
2014-11-27  9:05 ` Jiri Kosina
2014-11-28  1:20   ` Huang Bo
2014-12-01 20:11     ` Jiri Kosina [this message]
2014-12-02  5:58       ` [PATCHv4 " Huang Bo
2014-12-22 13:43         ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1412012111020.2524@pobox.suse.cz \
    --to=jkosina@suse.cz \
    --cc=huangbobupt@163.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).