From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752241AbbFREtd (ORCPT ); Thu, 18 Jun 2015 00:49:33 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:48227 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751452AbbFREt1 (ORCPT ); Thu, 18 Jun 2015 00:49:27 -0400 Date: Thu, 18 Jun 2015 14:49:15 +1000 (AEST) From: Finn Thain To: Geert Uytterhoeven cc: "linux-kernel@vger.kernel.org" , Linux/m68k , "linuxppc-dev@lists.ozlabs.org" , "linux-api@vger.kernel.org" Subject: Re: [RFC v2 23/24] m68k/mac: Fix PRAM accessors In-Reply-To: Message-ID: References: <20150614074607.242676098@telegraphics.com.au> <20150614074613.054681242@telegraphics.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, Further to my previous email, On Tue, 16 Jun 2015, in which I wrote: > > On Mon, 15 Jun 2015, Geert Uytterhoeven wrote: > > > > > More magic values... > > [...] The only useful RTC documentation I've ever come across is this: > http://mac.linux-m68k.org/devel/plushw.php This document appears to be Inside Macintosh vol. III ch. 2. It describes the early RTC chip that lacks two-byte operations and XPRAM, and pre-dates all Mac hardware supported in mainline Linux. But it does offer some useful data, though not enough to answer all of your criticisms (as I said). > [...] I think they should be applied across the entire file, and in a > different patch. Inconsistent use of such macros would be undesirable > IMHO. So, unless you have other ideas, I will revise this patch and insert an earlier patch to address existing code, and codify what little reliable chip data we have. --