linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Ioan-Adrian Ratiu <adi@adirat.com>
Cc: Josh Cartwright <joshc@ni.com>,
	pinglinux@gmail.com, linux-usb@vger.kernel.org,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock
Date: Thu, 19 Nov 2015 22:34:18 +0100 (CET)	[thread overview]
Message-ID: <alpine.LNX.2.00.1511192224490.20111@pobox.suse.cz> (raw)
In-Reply-To: <20151119183325.265f02af@adipc>

On Thu, 19 Nov 2015, Ioan-Adrian Ratiu wrote:

> But please understand further my reasoning for submitting this patch. 
> Consider if this is a bug in the wacom driver or in the usbhid core? IMO 
> this is a usbhid bug: the critical region in hid_ctrl() is too big, 
> there is no reason for the call to hid_input_report() to be protected by 
> usbhid->lock.

Hmm, it's actually true that we might not need usbhid->lock during 
hid_input_report() at the end of the day, as we shouldn't be doing any 
URB-related operations there, neither iofl are being manipulated.

If you have already done the full analysis that shows that usbhid->lock is 
indeed not needed, this absolutely needs to go into changelog as proper 
justification.

Could you please reformulate the changelog in this respect and resubmit?

Thanks,

-- 
Jiri Kosina
SUSE Labs


  reply	other threads:[~2015-11-19 21:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18 19:25 [PATCH] hid: usbhid: hid-core: fix recursive deadlock Ioan-Adrian Ratiu
2015-11-18 20:37 ` Jiri Kosina
2015-11-18 21:05   ` Ioan-Adrian Ratiu
2015-11-18 23:58     ` Josh Cartwright
2015-11-19  6:47       ` Ioan-Adrian Ratiu
2015-11-19  9:10         ` Jiri Kosina
2015-11-19 16:33           ` Ioan-Adrian Ratiu
2015-11-19 21:34             ` Jiri Kosina [this message]
2015-11-20 20:08               ` Ioan-Adrian Ratiu
2015-11-19  8:56     ` Jiri Kosina
2015-11-20 20:19 ` [PATCH v2] " Ioan-Adrian Ratiu
2015-11-29 10:29   ` Ioan-Adrian Ratiu
2016-01-21  1:28     ` Jason Gerecke
2016-01-21  9:36       ` Jiri Kosina
2015-12-01 16:36   ` Jiri Kosina
2015-12-02  0:00     ` Ping Cheng
2015-11-18 19:46 [PATCH] " Ioan-Adrian Ratiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1511192224490.20111@pobox.suse.cz \
    --to=jikos@kernel.org \
    --cc=adi@adirat.com \
    --cc=joshc@ni.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pinglinux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).