From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753232AbcC2XYP (ORCPT <rfc822;w@1wt.eu>);
	Tue, 29 Mar 2016 19:24:15 -0400
Received: from mx2.suse.de ([195.135.220.15]:40672 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1758371AbcC2XYM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 29 Mar 2016 19:24:12 -0400
Date: Wed, 30 Mar 2016 01:24:08 +0200 (CEST)
From: Jiri Kosina <jikos@kernel.org>
X-X-Sender: jkosina@pobox.suse.cz
To: Jessica Yu <jeyu@redhat.com>
cc: Rusty Russell <rusty@rustcorp.com.au>,
        Josh Poimboeuf <jpoimboe@redhat.com>, Petr Mladek <pmladek@suse.com>,
        Jonathan Corbet <corbet@lwn.net>, Miroslav Benes <mbenes@suse.cz>,
        linux-api@vger.kernel.org, live-patching@vger.kernel.org,
        x86@kernel.org, linux-kernel@vger.kernel.org,
        linux-s390@vger.kernel.org, linux-doc@vger.kernel.org,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: (mostly) Arch-independent livepatch
In-Reply-To: <20160329211330.GA1253@packer-debian-8-amd64.digitalocean.com>
Message-ID: <alpine.LNX.2.00.1603300122020.3656@cbobk.fhfr.pm>
References: <1458691399-20078-1-git-send-email-jeyu@redhat.com> <20160329211330.GA1253@packer-debian-8-amd64.digitalocean.com>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 29 Mar 2016, Jessica Yu wrote:

> > v6:
> > - Since we hard-code the field widths for the objname and symbol name
> >   for the sscanf() calls, which are supposed to correspond to the values
> >   of MODULE_NAME_LEN and KSYM_NAME_LEN, use BUILD_BUG_ON() to detect when
> >   the values of these constants deviate from the expected values.
> > - Squash the sample livepatch module patch into patch 4
> >   ("livepatch: reuse module loader code to write relocations") so
> >   git bisects don't break
> > - Don't need the klp_buf struct, just use plain char arrays to hold the
> >   output of sscanf(). Also, no need to clear the bufs after every
> >   invocation, as sscanf() takes care to put a null byte at the end of
> >   the bufs.
> > - Fix compiler kbuild errors for the !CONFIG_LIVEPATCH case
> > - Fixed some small module.c nits
> > 
> 
> Pinging Rusty, just in case this thread got buried :-)
> How do the module.c changes look?

Plus there are (admittedly indeed rather small and trivial) changes to 
s390 module loader, so I'd prefer to have Heiko's / Martin's Ack before 
merging this.

Hence, let me piggy back on this ping to Rusty, and let me ping Heiko and 
Martin as well (adding to CC explicitly to make sure this doesn't get lost 
in general noise).

Thanks,

-- 
Jiri Kosina
SUSE Labs