From: Jiri Kosina <jikos@kernel.org>
To: Jessica Yu <jeyu@redhat.com>
Cc: Miroslav Benes <mbenes@suse.cz>,
jpoimboe@redhat.com, pmladek@suse.com,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: klp: make object/func-walking helpers more robust
Date: Fri, 29 Apr 2016 10:35:29 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1604291032450.27368@cbobk.fhfr.pm> (raw)
In-Reply-To: <20160428182131.GA22885@packer-debian-8-amd64.digitalocean.com>
On Thu, 28 Apr 2016, Jessica Yu wrote:
> > #define klp_for_each_object(patch, obj) \
> > - for (obj = patch->objs; obj->funcs; obj++)
> > + for (obj = patch->objs; obj->funcs || obj->name; obj++)
>
> Remember that for patches to vmlinux, obj->name and obj->mod will also
> both be NULL. So if someone happens to forget to fill in obj->funcs
> for a vmlinux patch, we won't catch that case here. Perhaps we need a
> better way of determining whether we've reached the end of the array,
> or determining that the struct is truly empty..
I'd rather not over-compilcate it.
Admittedly, the change in the termination condition catches most of the
errors made by the patch author, but not all.
But there are many other places in the kernel where inserting an empty
item into the middle of statically initialized array will make the whole
thing explode, so let's not try to be more clever than necessary.
I plan to queue Miroslav's patch unless there are serious objections
raised.
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2016-04-29 8:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 14:34 [PATCH] klp: make object/func-walking helpers more robust Miroslav Benes
2016-04-28 18:21 ` Jessica Yu
2016-04-28 21:18 ` Josh Poimboeuf
2016-04-29 7:48 ` Miroslav Benes
2016-04-29 16:11 ` Jessica Yu
2016-04-29 8:35 ` Jiri Kosina [this message]
2016-04-29 16:23 ` [PATCH] " Josh Poimboeuf
2016-04-29 16:26 ` Jessica Yu
2016-04-29 22:06 ` [PATCH] " Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1604291032450.27368@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=jeyu@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).