From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752897AbcD2WGl (ORCPT ); Fri, 29 Apr 2016 18:06:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:54904 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752358AbcD2WGk (ORCPT ); Fri, 29 Apr 2016 18:06:40 -0400 Date: Sat, 30 Apr 2016 00:06:38 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Miroslav Benes cc: jpoimboe@redhat.com, jeyu@redhat.com, pmladek@suse.com, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] klp: make object/func-walking helpers more robust In-Reply-To: <1461854048-31473-1-git-send-email-mbenes@suse.cz> Message-ID: References: <1461854048-31473-1-git-send-email-mbenes@suse.cz> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Apr 2016, Miroslav Benes wrote: > Current object-walking helper checks the presence of obj->funcs to > determine the end of objs array in klp_object structure. This is > somewhat fragile because one can easily forget about funcs definition > during livepatch creation. In such a case the livepatch module is > successfully loaded and all objects after the incorrect one are omitted. > This is very confusing. Let's make the helper more robust and check also > for the other external member, name. Thus the helper correctly stops on > an empty item of the array. We need to have a check for obj->funcs in > klp_init_object() to make it work. > > The same applies to a func-walking helper. > > As a benefit we'll check for new_func member definition during the > livepatch initialization. There is no such check anywhere in the code > now. Applied to livepatching.git#for-4.7/core. Thanks, -- Jiri Kosina SUSE Labs