From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752813AbcFOHJR (ORCPT ); Wed, 15 Jun 2016 03:09:17 -0400 Received: from mx2.suse.de ([195.135.220.15]:60430 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751529AbcFOHJP (ORCPT ); Wed, 15 Jun 2016 03:09:15 -0400 Date: Wed, 15 Jun 2016 09:09:13 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Wim Osterholt cc: viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk Subject: Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 In-Reply-To: <20160614184308.GA6188@djo.tudelft.nl> Message-ID: References: <20160610230255.GA27770@djo.tudelft.nl> <20160614184308.GA6188@djo.tudelft.nl> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Jun 2016, Wim Osterholt wrote: > Surprising or not, the thusly compiled kernel ran fine and I could > handle floppies like before! (open(/dev/fd0,O_ACCMODE) succeeds.) Thanks for testing. Now next question -- what do you actually want to achieve with passing O_ACCMODE to open()? O_ACCMODE should primarily be used as a mask to use when extracting access mode bits from fcntl(F_GETFL) call. -- Jiri Kosina SUSE Labs