From: Jiri Kosina <jikos@kernel.org>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Ulrich Obergfell <uobergfe@redhat.com>,
Aaron Tomlin <atomlin@redhat.com>
Subject: Re: [PATCH] kernel/watchdog: use nmi registers snapshot in hardlockup handler
Date: Thu, 7 Jul 2016 10:30:20 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1607071029520.24757@cbobk.fhfr.pm> (raw)
In-Reply-To: <146771764784.86724.6006627197118544150.stgit@buzz>
On Tue, 5 Jul 2016, Konstantin Khlebnikov wrote:
> NMI handler doesn't call set_irq_regs(), so get_irq_regs() returns NULL or
> stale snapshot from beginning of IRQ interrupted by NMI. Registers from
> argument are always here and points to interrupted instruction and state.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> Cc: Jiri Kosina <jkosina@suse.cz>
Good catch, thanks for fixing my thinko.
Reviewed-by: Jiri Kosina <jkosina@suse.cz>
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2016-07-07 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 11:20 [PATCH] kernel/watchdog: use nmi registers snapshot in hardlockup handler Konstantin Khlebnikov
2016-07-07 8:30 ` Jiri Kosina [this message]
2016-07-08 21:02 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1607071029520.24757@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=atomlin@redhat.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=uobergfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).