From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753916AbcKBHrh (ORCPT ); Wed, 2 Nov 2016 03:47:37 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:46116 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751939AbcKBHrg (ORCPT ); Wed, 2 Nov 2016 03:47:36 -0400 Date: Wed, 2 Nov 2016 18:47:43 +1100 (AEDT) From: Finn Thain To: Ondrej Zary cc: Christoph Hellwig , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] g_NCR5380: Autoprobe IRQ by default In-Reply-To: <1477945112-25659-6-git-send-email-linux@rainbow-software.org> Message-ID: References: <1477945112-25659-1-git-send-email-linux@rainbow-software.org> <1477945112-25659-6-git-send-email-linux@rainbow-software.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Oct 2016, Ondrej Zary wrote: > IRQ probing seems to work fine now. Default to autoprobe for IRQ instead > of disabling it. > > Signed-off-by: Ondrej Zary > --- > drivers/scsi/g_NCR5380.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c > index 27fc499..6a08d3e 100644 > --- a/drivers/scsi/g_NCR5380.c > +++ b/drivers/scsi/g_NCR5380.c > @@ -52,9 +52,9 @@ > module_param(dtc_3181e, int, 0); > module_param(hp_c2502, int, 0); > > -static int irq[] = { 0, 0, 0, 0, 0, 0, 0, 0 }; > +static int irq[] = { IRQ_AUTO, IRQ_AUTO, IRQ_AUTO, IRQ_AUTO, IRQ_AUTO, IRQ_AUTO, IRQ_AUTO, IRQ_AUTO }; > module_param_array(irq, int, NULL, 0); > -MODULE_PARM_DESC(irq, "IRQ number(s)"); > +MODULE_PARM_DESC(irq, "IRQ number(s) (0=disable, 254=auto [default])"); > > static int base[] = { 0, 0, 0, 0, 0, 0, 0, 0 }; > module_param_array(base, int, NULL, 0); > I think this patch is incomplete and you should add these changes: diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c index 7299ad9..0bf0322 100644 --- a/drivers/scsi/g_NCR5380.c +++ b/drivers/scsi/g_NCR5380.c @@ -44,7 +44,7 @@ static int ncr_53c400; static int ncr_53c400a; static int dtc_3181e; static int hp_c2502; -module_param(ncr_irq, int, 0); +module_param(ncr_irq, int, IRQ_AUTO); module_param(ncr_addr, int, 0); module_param(ncr_5380, int, 0); module_param(ncr_53c400, int, 0); @@ -597,7 +597,7 @@ static int __init generic_NCR5380_init(void) int ret = 0; /* compatibility with old-style parameters */ - if (irq[0] == 0 && base[0] == 0 && card[0] == -1) { + if (irq[0] == IRQ_AUTO && base[0] == 0 && card[0] == -1) { irq[0] = ncr_irq; base[0] = ncr_addr; if (ncr_5380) --