From: Finn Thain <fthain@telegraphics.com.au>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] g_NCR5380: Add IRQ auto-configuration for HP C2502
Date: Thu, 3 Nov 2016 13:17:18 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LNX.2.00.1611022056450.12392@nippy.intranet> (raw)
In-Reply-To: <201611020929.22464.linux@rainbow-software.org>
On Wed, 2 Nov 2016, Ondrej Zary wrote:
> > Also, you've ignored the irq module parameters. From the user's point
> > of view, surely the least surprising thing is to attempt to configure
> > the card for whatever irq the user asked for.
>
> I haven't. NCR5380_find_irq is only called when irq is set to IRQ_AUTO.
>
My mistake.
> > If the specified irq isn't supported by the board, just log an error
> > and fail. If you want to be user friendly, print a message to tell
> > them what irqs the card supports.
>
> If the IRQ is not supported (or does not work), user gets a warning and
> the driver continues with IRQ disabled.
>
> > If the user asks for IRQ_AUTO, just configure the board for a
> > hard-coded default, say 9, and print a warning message to say so.
>
> The card is almost Plug&Play. The base address is already configured
> automatically by the driver so doing the same for IRQ makes sense.
Why don't we see any other drivers doing this?
If the card was really plug and play, I expect we would just call
pnp_irq(), as the other PNP drivers do.
>
> > Either way, if request_irq fails just continue with NO_IRQ, as per
> > usual.
> >
> > To me that's the most flexible and least surprising behaviour. But
> > again, if someone with more ISA knowledge wishes to weigh in, that's
> > fine too.
--
next prev parent reply other threads:[~2016-11-03 2:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 20:18 [PATCH 0/6] (g_)NCR5380: Improve IRQ probing and some fixes Ondrej Zary
2016-10-31 20:18 ` [PATCH 1/6] NCR5380: Use probe_irq_*() for IRQ probing Ondrej Zary
2016-11-02 7:45 ` Finn Thain
2016-11-02 8:00 ` Ondrej Zary
2016-11-03 2:16 ` Finn Thain
2016-10-31 20:18 ` [PATCH 2/6] g_NCR5380: Test the IRQ before accepting it Ondrej Zary
2016-11-02 7:45 ` Finn Thain
2016-11-02 19:16 ` Ondrej Zary
2016-11-03 2:17 ` Finn Thain
2016-10-31 20:18 ` [PATCH 3/6] g_NCR5380: Check for chip presence before calling NCR5380_init() Ondrej Zary
2016-11-02 7:46 ` Finn Thain
2016-10-31 20:18 ` [PATCH 4/6] g_NCR5380: Add IRQ auto-configuration for HP C2502 Ondrej Zary
2016-11-02 7:46 ` Finn Thain
2016-11-02 8:29 ` Ondrej Zary
2016-11-03 2:17 ` Finn Thain [this message]
2016-11-03 8:00 ` Ondrej Zary
2016-11-04 3:00 ` Finn Thain
2016-10-31 20:18 ` [PATCH 5/6] g_NCR5380: Autoprobe IRQ by default Ondrej Zary
2016-11-02 7:47 ` Finn Thain
2016-12-03 0:39 ` Finn Thain
2016-10-31 20:18 ` [PATCH 6/6] g_NCR5380: Fix release region in error handling Ondrej Zary
2016-11-02 7:49 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1611022056450.12392@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rainbow-software.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).