From: Jiri Kosina <jikos@kernel.org>
To: "Ooi, Joyce" <joyce.ooi@intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kweh Hock Leong <hock.leong.kweh@intel.com>,
Ong Boon Leong <boon.leong.ong@intel.com>,
Lay Kuan Loon <kuan.loon.lay@intel.com>
Subject: Re: [PATCH] hid: sensor: fix input and feature attributes in HID sensor custom sysfs interface
Date: Sat, 5 Nov 2016 16:58:17 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1611051657590.29400@cbobk.fhfr.pm> (raw)
In-Reply-To: <1478170515-24436-1-git-send-email-joyce.ooi@intel.com>
On Thu, 3 Nov 2016, Ooi, Joyce wrote:
> User is unable to access to input-X-yyy and feature-X-yyy where
> X is a hex value and more than 9 (e.g. input-a-yyy, feature-b-yyy) in HID
> sensor custom sysfs interface.
> This is because when creating the attribute, the attribute index is
> written to using %x (hex). However, when reading and writing values into
> the attribute, the attribute index is scanned using %d (decimal). Hence,
> user is unable to access to attributes with index in hex values
> (e.g. 'a', 'b', 'c') but able to access to attributes with index in
> decimal values (e.g. 1, 2, 3,..).
> This fix will change input-%d-%x-%s and feature-%d-%x-%s to input-%x-%x-%s
> and feature-%x-%x-%s in show_values() and store_values() accordingly.
>
> Signed-off-by: Ooi, Joyce <joyce.ooi@intel.com>
Applied to hid.git#for-4.9/upstream-fixes. Thanks,
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2016-11-05 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 10:55 [PATCH] hid: sensor: fix input and feature attributes in HID sensor custom sysfs interface Ooi, Joyce
2016-11-04 14:03 ` Benjamin Tissoires
2016-11-04 17:49 ` Srinivas Pandruvada
2016-11-05 15:58 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1611051657590.29400@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=boon.leong.ong@intel.com \
--cc=hock.leong.kweh@intel.com \
--cc=jic23@kernel.org \
--cc=joyce.ooi@intel.com \
--cc=kuan.loon.lay@intel.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).