From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933605AbcLIOgh (ORCPT ); Fri, 9 Dec 2016 09:36:37 -0500 Received: from mx2.suse.de ([195.135.220.15]:38829 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932594AbcLIOge (ORCPT ); Fri, 9 Dec 2016 09:36:34 -0500 Date: Fri, 9 Dec 2016 15:36:27 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Rob Herring cc: Dmitry Torokhov , Benjamin Tissoires , Doug Anderson , Brian Norris , Caesar Wang , "open list:ARM/Rockchip SoC..." , "linux-input@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mark Rutland Subject: Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support In-Reply-To: Message-ID: References: <1480555288-142791-1-git-send-email-briannorris@chromium.org> <20161201143434.GD1280@mail.corp.redhat.com> <20161201172448.GA46688@google.com> <20161205235908.rmiyd7io4kddple6@rob-hp-laptop> <20161206084803.GR1280@mail.corp.redhat.com> <20161208154145.GA30888@mail.corp.redhat.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 8 Dec 2016, Rob Herring wrote: > > And if tomorrow there is Elan device that is drop-in compatible (same > > connector, etc) with Wacom i2c-hid, will you ask for Elan-specific > > binding? Atmel? Weida? They all need to be powered up ultimately. > > Yes, I will. What advantage does that bring? > That in no way means the OS driver has to know about each and every one. > If they can all claim compatibility with Wacom (including power > control), then they can have a Wacom compatible string too. Or you can > just never tell me that there's a different manufacturer and I won't > care as long you don't need different control. But soon as a device > needs another power rail, GPIO or different timing, then you'd better > have a new compatible string. Again, I simply don't understand what advantage does the aproach you are trying to use bring. HID over I2C is a generic protocol. Sure, we need to have quirks for device-specific bugs, and in such cases enumerate particular devices. But we don't need DT for that at all. -- Jiri Kosina SUSE Labs