From: Jan Engelhardt <jengelh@medozas.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] treewide: fix memory corruptions when TASK_COMM_LEN != 16
Date: Wed, 1 Feb 2012 03:15:50 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.01.1202010257240.29848@frira.zrqbmnf.qr> (raw)
In-Reply-To: <20120131174914.8ce5291d.akpm@linux-foundation.org>
On Wednesday 2012-02-01 02:49, Andrew Morton wrote:
>>
>> Did my patch not change the existing code sites using ->comm
>> to always copy at most min(userbufsize aka 16, sizeof(t->comm)) bytes,
>> thereby keeping the promise to userspace while at the same time
>> making TASK_COMM_LEN's value freely choosable?
>
>That change is pretty pointless as long as we don't provide APIs to let
>userspace access the expanded size. And I've explained why we cannot
>alter the existing APIs.
Ah yes, indeed. My reason for augmenting the size of t->comm was so
that `ps afx` could show a more complete name of certain kernel
threads' names. In this case, the kernel delivers the name via
procfs via seq_printf("%s, t->comm), as do a few debug statements
in the fashion of pr_debug("%s/%u ate my CPU", t->comm, t->pid).
So maybe it was not /completely/ pointless.
next prev parent reply other threads:[~2012-02-01 2:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-21 22:09 [PATCH 1/2] treewide: fix memory corruptions when TASK_COMM_LEN != 16 Jan Engelhardt
2012-01-21 22:09 ` [PATCH 2/2] treewide: avoid truncation of process name Jan Engelhardt
2012-01-24 21:54 ` [PATCH 1/2] treewide: fix memory corruptions when TASK_COMM_LEN != 16 Andrew Morton
2012-02-01 1:15 ` Jan Engelhardt
2012-02-01 1:23 ` Andrew Morton
2012-02-01 1:35 ` Jan Engelhardt
2012-02-01 1:49 ` Andrew Morton
2012-02-01 2:15 ` Jan Engelhardt [this message]
2012-02-01 3:01 ` Andrew Morton
2012-02-22 12:48 ` Jan Engelhardt
2012-02-22 20:58 ` Andrew Morton
2012-02-23 9:09 ` Jan Engelhardt
2012-02-23 9:57 ` Andrew Morton
2012-02-23 11:19 ` Jan Engelhardt
2012-02-23 17:30 ` Andrew Morton
2012-02-23 21:59 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.01.1202010257240.29848@frira.zrqbmnf.qr \
--to=jengelh@medozas.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).