From: Jan Engelhardt <jengelh@inai.de>
To: Jim Rees <rees@umich.edu>
Cc: Bernd Petrovitsch <bernd@petrovitsch.priv.at>,
"J. Bruce Fields" <bfields@fieldses.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] strings: helper for maximum decimal encoding of an unsigned integer
Date: Fri, 14 Sep 2012 15:37:37 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.01.1209141501450.18169@frira.zrqbmnf.qr> (raw)
In-Reply-To: <20120914123014.GB29160@umich.edu>
On Friday 2012-09-14 14:30, Jim Rees wrote in an odd quote style
(the > are mine):
>Bernd Petrovitsch wrote:
>
> A pure K&R-C version would use a string:
> ---- snip ----
> #define base10len(i) "\0x1\0x3\0x5\0x8\0x0A\0x0D\0x0F\0x11\0x14"[sizeof(i)]
> ---- snip ----
> (if I converted them properly into hexadecimal) and that gives a "char"
> which is happily promoted to whatever one needs in that place.
>
>1. That may give you a signed char on some architectures, which is not what
>you want (although it doesn't matter since the values are all < 128)
Convert.
>2. If you put this in a .h, you'll get multiple copies of the array
The gcc compiler is smart enough to optimize that away. A string
literal is known at compile-time and immutable by definition.
sizeof(i) is a compile-time constant, also by definition. Therefore,
any "foo"[bar] is resolvable at compile time. Even gcc -O0 knows that.
That makes it possible to write
char f[base10len(whatever)];
without depending on C99 VLAs.
>Pure K&R:
>
>base10.h:
>extern unsigned char base10len_vals[];
>#define base10len(i) (base10len_vals[sizeof(i)])
>
>base10.c:
>unsigned char base10len_vals[] = {1,3,5,8,10,13,15,17,20};
>
>But I still like my way better.
Your way does not function as originally desired.
* base10len(i) no longer expands to a compile-time constant
* you will definitely have a variable base10len_vals in your
objects, so you waste a read operation whenever it is used.
next prev parent reply other threads:[~2012-09-14 13:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 21:29 [PATCH] strings: helper for maximum decimal encoding of an unsigned integer J. Bruce Fields
2012-08-21 21:22 ` Jim Rees
2012-08-21 22:06 ` Al Viro
2012-08-21 22:19 ` J. Bruce Fields
2012-08-22 0:03 ` Jim Rees
2012-09-10 6:19 ` Jan Engelhardt
2012-09-14 9:17 ` Bernd Petrovitsch
2012-09-14 12:30 ` Jim Rees
2012-09-14 13:14 ` J. Bruce Fields
2012-09-14 13:18 ` Bernd Petrovitsch
2012-09-14 13:51 ` Jim Rees
2012-09-14 13:37 ` Jan Engelhardt [this message]
2012-09-14 13:54 ` Jim Rees
2012-09-14 12:59 ` Jan Engelhardt
2012-09-14 13:46 ` Jim Rees
2012-09-14 14:25 ` Jan Engelhardt
2012-09-14 15:00 ` Bernd Petrovitsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.01.1209141501450.18169@frira.zrqbmnf.qr \
--to=jengelh@inai.de \
--cc=bernd@petrovitsch.priv.at \
--cc=bfields@fieldses.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rees@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).