From: James Morris <jmorris@namei.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
Gergely Nagy <algernon@balabit.hu>,
david@lang.hm, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Marc Koschewski <marc@osknowledge.org>,
lkml <linux-kernel@vger.kernel.org>,
Nick Bowler <nbowler@elliptictech.com>
Subject: Re: [PATCH 1/1] cap_syslog: don't refuse cap_sys_admin for now (v3)
Date: Fri, 11 Feb 2011 09:59:07 +1100 (EST) [thread overview]
Message-ID: <alpine.LRH.2.00.1102110957380.27143@tundra.namei.org> (raw)
In-Reply-To: <AANLkTin-2uDkjPuSPmUE_HZdpxk9zd=Qop=nf==jsyLA@mail.gmail.com>
On Thu, 10 Feb 2011, Linus Torvalds wrote:
> On Thu, Feb 10, 2011 at 6:40 AM, Serge E. Hallyn <serge@hallyn.com> wrote:
> >
> > Please apply.
>
> Hmm. So I detest the duplication and the ugly resulting code. It was
> a bit hard to follow before, now it's just nasty.
>
> Why not make this all into some nicer helper functions instead -
> something simple like the attached?
>
> UNTESTED! I'm not going to apply it unless I get acks/tested-by's.
Reviewed-by: James Morris <jmorris@namei.org>
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2011-02-10 22:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 14:40 [PATCH 1/1] cap_syslog: don't refuse cap_sys_admin for now (v3) Serge E. Hallyn
2011-02-10 19:16 ` Linus Torvalds
2011-02-10 22:43 ` Serge E. Hallyn
2011-02-10 22:59 ` James Morris [this message]
2011-02-11 16:32 ` Serge E. Hallyn
2011-08-03 16:48 ` [PATCH/RFC] cap_syslog: make CAP_SYS_ADMIN deprecation notice less alarming Jonathan Nieder
2011-08-04 1:28 ` James Morris
2011-08-04 4:39 ` Serge E. Hallyn
2011-08-05 13:45 ` James Morris
2011-08-05 18:50 ` Linus Torvalds
2011-08-08 4:22 ` [PATCH v2] cap_syslog: don't use WARN_ONCE for CAP_SYS_ADMIN deprecation warning Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.00.1102110957380.27143@tundra.namei.org \
--to=jmorris@namei.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=algernon@balabit.hu \
--cc=david@lang.hm \
--cc=linux-kernel@vger.kernel.org \
--cc=marc@osknowledge.org \
--cc=nbowler@elliptictech.com \
--cc=serge@hallyn.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).