From: Mikulas Patocka <mpatocka@redhat.com>
To: Huaisheng Ye <yehs2007@zoho.com>
Cc: snitzer@redhat.com, agk@redhat.com, prarit@redhat.com,
chengnt@lenovo.com, dm-devel@redhat.com,
linux-kernel@vger.kernel.org, Huaisheng Ye <yehs1@lenovo.com>
Subject: Re: [PATCH] dm-writecache: remove unused member page_offset in writeback_struct
Date: Tue, 23 Apr 2019 06:39:15 -0400 (EDT) [thread overview]
Message-ID: <alpine.LRH.2.02.1904230638030.11112@file01.intranet.prod.int.rdu2.redhat.com> (raw)
In-Reply-To: <20190420162017.6052-1-yehs2007@zoho.com>
On Sun, 21 Apr 2019, Huaisheng Ye wrote:
> From: Huaisheng Ye <yehs1@lenovo.com>
>
> The structure member page_offset in writeback_struct never has been
> used actually. Remove it.
>
> Signed-off-by: Huaisheng Ye <yehs1@lenovo.com>
Acked-by: Mikulas Patocka <mpatocka@redhat.com>
> ---
> drivers/md/dm-writecache.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c
> index cfbbfbc..ddf1732 100644
> --- a/drivers/md/dm-writecache.c
> +++ b/drivers/md/dm-writecache.c
> @@ -190,7 +190,6 @@ struct writeback_struct {
> struct dm_writecache *wc;
> struct wc_entry **wc_list;
> unsigned wc_list_n;
> - unsigned page_offset;
> struct page *page;
> struct wc_entry *wc_list_inline[WB_LIST_INLINE];
> struct bio bio;
> @@ -1481,7 +1480,6 @@ static void __writecache_writeback_pmem(struct dm_writecache *wc, struct writeba
> bio->bi_end_io = writecache_writeback_endio;
> bio_set_dev(bio, wc->dev->bdev);
> bio->bi_iter.bi_sector = read_original_sector(wc, e);
> - wb->page_offset = PAGE_SIZE;
> if (max_pages <= WB_LIST_INLINE ||
> unlikely(!(wb->wc_list = kmalloc_array(max_pages, sizeof(struct wc_entry *),
> GFP_NOIO | __GFP_NORETRY |
> --
> 1.8.3.1
>
>
prev parent reply other threads:[~2019-04-23 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-20 16:20 [PATCH] dm-writecache: remove unused member page_offset in writeback_struct Huaisheng Ye
2019-04-23 10:39 ` Mikulas Patocka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.02.1904230638030.11112@file01.intranet.prod.int.rdu2.redhat.com \
--to=mpatocka@redhat.com \
--cc=agk@redhat.com \
--cc=chengnt@lenovo.com \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=snitzer@redhat.com \
--cc=yehs1@lenovo.com \
--cc=yehs2007@zoho.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).