From: Mikulas Patocka <mpatocka@redhat.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Alan Stern <stern@rowland.harvard.edu>,
Andrea Parri <parri.andrea@gmail.com>,
Will Deacon <will@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Boqun Feng <boqun.feng@gmail.com>,
Nicholas Piggin <npiggin@gmail.com>,
David Howells <dhowells@redhat.com>,
Jade Alglave <j.alglave@ucl.ac.uk>,
Luc Maranget <luc.maranget@inria.fr>,
"Paul E. McKenney" <paulmck@kernel.org>,
Akira Yokosawa <akiyks@gmail.com>,
Daniel Lustig <dlustig@nvidia.com>,
Joel Fernandes <joel@joelfernandes.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] Add a read memory barrier to wait_on_buffer
Date: Sun, 31 Jul 2022 09:41:02 -0400 (EDT) [thread overview]
Message-ID: <alpine.LRH.2.02.2207310920390.6506@file01.intranet.prod.int.rdu2.redhat.com> (raw)
In-Reply-To: <CAMj1kXFYRNrP2k8yppgfdKg+CxWeYfHTbzLBuyBqJ9UVAR_vaQ@mail.gmail.com>
On Sun, 31 Jul 2022, Ard Biesheuvel wrote:
> This has little to do with speculation, so better to drop this S bomb
> from your commit message. This is about concurrency and weak memory
> ordering.
Yes.
> This doesn't seem like a very robust fix to me, tbh - I suppose this
> makes the symptom you encountered go away, but the underlying issue
> remains afaict.
>
> Given that the lock and uptodate fields etc are just bits in a
> bitfield, wouldn't it be better to use cmpxchg() with acquire/release
> semantics (as appropriate) to manage these bits?
The kernel already uses clear_bit_unlock, test_and_set_bit_lock and
wait_on_bit_lock_io to manage the BH_Lock bit - and they have
acquire/release semantics.
The only problem is that test_bit doesn't provide any memory barriers.
Should we add the barrier to buffer_locked() instead of wait_on_buffer()?
Perhaps it would fix more bugs - in reiserfs, there's this piece of code:
if (buffer_locked(bh)) {
spin_unlock(lock);
wait_on_buffer(bh);
spin_lock(lock);
}
if (!buffer_uptodate(bh)) {
ret = -EIO;
}
or this:
if (buffer_locked(bh)) {
int depth;
PROC_INFO_INC(sb, scan_bitmap.wait);
depth = reiserfs_write_unlock_nested(sb);
__wait_on_buffer(bh);
reiserfs_write_lock_nested(sb, depth);
}
BUG_ON(!buffer_uptodate(bh));
BUG_ON(atomic_read(&bh->b_count) == 0);
That assumes that buffer_locked provides a barrier.
Mikulas
next prev parent reply other threads:[~2022-07-31 13:41 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-31 11:43 [PATCH] Add a read memory barrier to wait_on_buffer Mikulas Patocka
2022-07-31 12:00 ` Ard Biesheuvel
2022-07-31 13:41 ` Mikulas Patocka [this message]
2022-07-31 15:08 ` [PATCH v2] make buffer_locked provide an acquire semantics Mikulas Patocka
2022-07-31 16:51 ` Linus Torvalds
2022-07-31 17:30 ` Paul E. McKenney
2022-07-31 22:48 ` Matthew Wilcox
2022-08-01 3:20 ` Paul E. McKenney
2022-08-01 15:41 ` Will Deacon
2022-08-01 19:20 ` Paul E. McKenney
2022-08-02 8:54 ` Will Deacon
2022-08-02 13:49 ` Paul E. McKenney
2022-08-02 15:29 ` Paul E. McKenney
2022-07-31 20:39 ` Mikulas Patocka
2022-07-31 20:40 ` [PATCH v3 1/2] wait_bit: do read barrier after testing a bit Mikulas Patocka
2022-07-31 20:57 ` Linus Torvalds
2022-08-01 10:40 ` Mikulas Patocka
2022-08-01 10:43 ` [PATCH v4 2/2] change buffer_locked, so that it has acquire semantics Mikulas Patocka
2022-08-01 14:37 ` Matthew Wilcox
2022-08-01 15:01 ` Mikulas Patocka
2022-08-05 3:22 ` Matthew Wilcox
2022-08-07 11:37 ` [PATCH v5] add barriers to buffer functions Mikulas Patocka
2022-08-07 14:50 ` Matthew Wilcox
2022-08-08 14:26 ` Mikulas Patocka
2022-08-08 14:40 ` Matthew Wilcox
2022-08-08 14:57 ` Mikulas Patocka
2022-08-08 15:31 ` Paul E. McKenney
2022-08-08 15:39 ` Matthew Wilcox
2022-08-09 18:32 ` [PATCH v6] add barriers to buffer_uptodate and set_buffer_uptodate Mikulas Patocka
2022-08-09 19:44 ` Matthew Wilcox
2022-08-09 22:06 ` Linus Torvalds
2022-08-01 10:42 ` [PATCH v4 1/2] introduce test_bit_acquire and use it in wait_on_bit Mikulas Patocka
2022-08-01 15:54 ` Will Deacon
2022-08-01 16:12 ` Mikulas Patocka
2022-08-01 18:17 ` Boqun Feng
2022-08-02 8:00 ` David Laight
2022-08-02 8:40 ` Will Deacon
2022-08-02 11:38 ` Mikulas Patocka
2022-08-02 13:36 ` Will Deacon
2022-08-02 15:57 ` Mikulas Patocka
2022-08-01 0:27 ` [PATCH v3 1/2] wait_bit: do read barrier after testing a bit Alan Stern
2022-07-31 20:43 ` [PATCH v3 2/2] make buffer_locked provide an acquire semantics Mikulas Patocka
2022-07-31 20:51 ` Linus Torvalds
2022-07-31 22:14 ` Matthew Wilcox
2022-07-31 22:31 ` Ard Biesheuvel
2022-07-31 22:48 ` Ard Biesheuvel
2022-07-31 20:46 ` [PATCH v2] " Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.02.2207310920390.6506@file01.intranet.prod.int.rdu2.redhat.com \
--to=mpatocka@redhat.com \
--cc=akiyks@gmail.com \
--cc=ardb@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=j.alglave@ucl.ac.uk \
--cc=joel@joelfernandes.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=npiggin@gmail.com \
--cc=parri.andrea@gmail.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).