From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754941AbbG3IXu (ORCPT ); Thu, 30 Jul 2015 04:23:50 -0400 Received: from tundra.namei.org ([65.99.196.166]:33169 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750838AbbG3IXt (ORCPT ); Thu, 30 Jul 2015 04:23:49 -0400 Date: Thu, 30 Jul 2015 18:23:18 +1000 (AEST) From: James Morris To: Baolin Wang cc: serge.hallyn@canonical.com, arnd@arndb.de, tglx@linutronix.de, linux-kernel@vger.kernel.org, james.l.morris@oracle.com, serge@hallyn.com, paul@paul-moore.com, john.johansen@canonical.com, sds@tycho.nsa.gov, casey@schaufler-ca.com, penguin-kernel@I-love.SAKURA.ne.jp, neilb@suse.de, edumazet@google.com, jlayton@primarydata.com, linux-security-module@vger.kernel.org, y2038@lists.linaro.org Subject: Re: [PATCH v2 3/5] security: Introduce security_settime64() In-Reply-To: <50b61ce23a73b68c3c55d6d9aa416af29001205a.1438170155.git.baolin.wang@linaro.org> Message-ID: References: <50b61ce23a73b68c3c55d6d9aa416af29001205a.1438170155.git.baolin.wang@linaro.org> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Jul 2015, Baolin Wang wrote: > security_settime() uses a timespec, which is not year 2038 safe > on 32bit systems. Thus this patch introduces the security_settime64() > function with timespec64 type. We also convert the cap_settime() helper > function to use the 64bit types. > > Move the security_settime() to the head file as a inline function for > removing that inline helper when following up patches are fixed the > call sites. > > None of the existing hooks is using the timespec argument and therefor > the patch is not doing any functional changes. > > Signed-off-by: Baolin Wang Reviewed-by: James Morris