linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Meelis Roos <mroos@linux.ee>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: make *config regression: pkg-build
Date: Sun, 19 Aug 2018 14:15:19 +0300 (EEST)	[thread overview]
Message-ID: <alpine.LRH.2.21.1808191406030.12334@math.ut.ee> (raw)

Just tried to run 'make menuconfig' on v4.18-10568-g08b5fa819970 and 
found a bad surprise:

'make *config' requires 'pkg-config'. Please install it.
make[1]: *** [scripts/kconfig/Makefile:219: scripts/kconfig/.mconf-cfg] Error 1

This is clearly a regression - I have libncurses devele pakcage 
installed in the default system location (as do 99%+ on actuall 
develeopers proobably) and in this case, pkg-config is useless. 
pkg-config is needed only when libraries and headers are installed in 
non-default locations but it is bad to require installation of 
pkg-config on all the machines where make menuconfig would be possibly 
run (for example, I have a aboult 100 machine kernel testbed with 
self-hosted kernel compilation and machine-specific kernel 
configurations that ocassionally need tweaking).

I notice 4.18 complained it can not find pkg-config but still worked. 
This is clearly better than now.

If we want to support developers with libraries in non-default 
locations, why not - but the common case of system include path should 
work without any trouble or warnings. For exaple, test if compilation 
against ncurses works, and if not retry it with pkg-config (and error 
out if it does not give working result).

-- 
Meelis Roos (mroos@linux.ee)

             reply	other threads:[~2018-08-19 11:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-19 11:15 Meelis Roos [this message]
2018-08-19 15:37 ` make *config regression: pkg-build Randy Dunlap
2018-08-31  9:42   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LRH.2.21.1808191406030.12334@math.ut.ee \
    --to=mroos@linux.ee \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).