From: Jaskaran Singh Khurana <jaskarankhurana@linux.microsoft.com>
To: Milan Broz <gmazyland@gmail.com>
Cc: linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-fsdevel@vger.kernel.org, agk@redhat.com,
snitzer@redhat.com, dm-devel@redhat.com, jmorris@namei.org,
scottsh@microsoft.com, ebiggers@google.com,
Mikulas Patocka <mpatocka@redhat.com>
Subject: Re: [RFC PATCH v3 1/1] Add dm verity root hash pkcs7 sig validation
Date: Mon, 10 Jun 2019 16:27:21 -0700 (PDT) [thread overview]
Message-ID: <alpine.LRH.2.21.1906101624350.31134@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.inter> (raw)
In-Reply-To: <54170d18-31c7-463d-10b5-9af8b666df0f@gmail.com>
On Sat, 8 Jun 2019, Milan Broz wrote:
> On 08/06/2019 00:31, Jaskaran Khurana wrote:
>> The verification is to support cases where the roothash is not secured by
>
>> + key = request_key(&key_type_user,
>> + key_desc, NULL);
>> + if (IS_ERR(key))
>> + return PTR_ERR(key);
>
> You will need dependence on keyring here (kernel can be configured without it),
> try to compile it without CONFIG_KEYS selected.
>
> I think it is ok that DM_VERITY_VERIFY_ROOTHASH_SIG can directly require CONFIG_KEYS.
> (Add depends on CONFIG_KEYS in KConfig)
>
DM_VERITY_VERIFY_ROOTHASH_SIG selects SYSTEM_DATA_VERIFICATION and
SYSTEM_DATA_VERIFICATION selects KEYS so we should be OK here.
>
> Thanks,
> Milan
>
Thanks,
Jaskaran.
next prev parent reply other threads:[~2019-06-10 23:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 22:31 [RFC PATCH v3 0/1] Add dm verity root hash pkcs7 sig validation Jaskaran Khurana
2019-06-07 22:31 ` [RFC PATCH v3 1/1] " Jaskaran Khurana
2019-06-08 9:11 ` Milan Broz
2019-06-10 21:22 ` Jaskaran Singh Khurana
2019-06-10 23:27 ` Jaskaran Singh Khurana [this message]
2019-06-11 5:31 ` James Morris
2019-06-08 8:46 ` [RFC PATCH v3 0/1] " Milan Broz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1906101624350.31134@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.inter \
--to=jaskarankhurana@linux.microsoft.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=ebiggers@google.com \
--cc=gmazyland@gmail.com \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=scottsh@microsoft.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).