From: James Morris <jmorris@namei.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Nayna Jain <nayna@linux.ibm.com>,
Mimi Zohar <zohar@linux.ibm.com>,
"Serge E . Hallyn" <serge@hallyn.com>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] integrity: Fix __integrity_init_keyring() section mismatch
Date: Mon, 17 Jun 2019 11:11:05 -0700 (PDT) [thread overview]
Message-ID: <alpine.LRH.2.21.1906171110550.25545@namei.org> (raw)
In-Reply-To: <20190617074452.12901-1-geert@linux-m68k.org>
On Mon, 17 Jun 2019, Geert Uytterhoeven wrote:
> With gcc-4.6.3:
>
> WARNING: vmlinux.o(.text.unlikely+0x24c64): Section mismatch in reference from the function __integrity_init_keyring() to the function .init.text:set_platform_trusted_keys()
> The function __integrity_init_keyring() references
> the function __init set_platform_trusted_keys().
> This is often because __integrity_init_keyring lacks a __init
> annotation or the annotation of set_platform_trusted_keys is wrong.
>
> Indeed, if the compiler decides not to inline __integrity_init_keyring(),
> a warning is issued.
>
> Fix this by adding the missing __init annotation.
>
> Fixes: 9dc92c45177ab70e ("integrity: Define a trusted platform keyring")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: James Morris <jamorris@linux.microsoft.com>
--
James Morris
<jmorris@namei.org>
prev parent reply other threads:[~2019-06-17 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 7:44 [PATCH] integrity: Fix __integrity_init_keyring() section mismatch Geert Uytterhoeven
2019-06-17 14:04 ` Nayna
2019-06-17 18:11 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1906171110550.25545@namei.org \
--to=jmorris@namei.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.ibm.com \
--cc=serge@hallyn.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).